batch: add #[non_exhaustive] to remaining pub enums (workspace sweep CI-949)

[bug-ops]

Description

Workspace-wide sweep at CI-949 (HEAD 42eb447) identified pub enums still missing `#[non_exhaustive]`. Each missing attribute is a semver-breaking change for any downstream crate that match-exhaustively on these types. This batch covers all remaining gaps not addressed by open issues #4703, #4725, #4733, #4734, #4735, #4736.

Affected Enums

zeph-acp

• AcpError (src/error.rs:21)
• LspDiagnosticSeverity, LspSymbolKind (src/lsp/types.rs:42, 97)

zeph-core/agent

• BuildError (agent/builder.rs:75)
• OrchestrationFailure, SkillOperationFailure, AgentError (agent/error.rs:11, 37, 58)
• ToolCategory (agent/rate_limiter.rs:24)
• PrefixState (agent/speculative/partial_json.rs:35)
• ToolOutcome, PatternError (agent/speculative/paste.rs:39, 46)
• PredictionSource (agent/speculative/prediction.rs:23)
• VigilRiskLevel, RiskSignal, RiskLevel (agent/trajectory.rs:30, 48, 126)
• VigilAction, VigilVerdict (agent/vigil.rs:42, 51)

zeph-core/other

• ConfigWatcherError, ConfigEvent (config_watcher.rs:11, 23)
• ComponentStatus, DaemonError (daemon.rs:14, 22)
• SpanStatus (debug_dump/trace.rs:76)
• FileWatcherError (file_watcher.rs:11)
• GoalStatus, GoalError, SupervisorError (goal/state.rs:21, goal/store.rs:19, goal/supervisor.rs:20)
• InstructionEvent (instructions.rs:14)
• JsonEvent (json_event_sink.rs:32)
• McpServerConnectionStatus (metrics.rs:111)
• TurnExitStatus, NotifyTestError (notifications.rs:58, 222)
• PipelineError (pipeline/mod.rs:14)
• BootstrapError (provider_factory.rs:37)
• ParseError, ChatJsonError (quality/parser.rs:18, 27)

zeph-orchestration

• PlanCommand (command.rs:15)
• PlanCacheError (plan_cache.rs:217)

zeph-skills

• ScanVerdict (semantic_scanner.rs:87)

zeph-tools

• PolicyDecision (adversarial_policy.rs:19)
• CompressionError (compression/mod.rs:48)
• ModerationError (moderation.rs:68)
• PolicyDecision, PolicyCompileError (policy.rs:32, 39)
• InvocationHint (registry.rs:8)
• SandboxError (sandbox/mod.rs:162)
• ScopeError (scope.rs:64)
• UtilityAction (utility.rs:114)
• VerificationResult (verifier.rs:41)

zeph-vault

• AgeVaultError (age.rs:40)

Fix

Add #[non_exhaustive] above each listed pub enum. Update any exhaustive match sites in downstream crates with a wildcard _ => unreachable!() or _ => {} arm as appropriate.

References

• refactor: add #[non_exhaustive] to remaining extensible pub enums workspace-wide #4658 — initial workspace-wide #[non_exhaustive] PR
• fix: add #[non_exhaustive] to ChannelError, sanitizer errors, SubAgentError #4737 — ChannelError/sanitizer/SubAgentError batch
• CI-949 architecture audit

[bug-ops]

CI-950 sweep update (HEAD 8ed9fdb)

After #4742 landed (ToolDispatchError, ContextError, CompactionOutcome, SubgoalState, PersistenceError), the remaining count is 99 pub enums across the workspace.

Notable additions found vs CI-949 list:

• zeph-a2a: TaskEvent, Role, Part
• zeph-acp: AcpClientError, SessionStatus
• zeph-bench: BenchError, Role
• zeph-config: ThinkingConfig, CacheTtl, ProviderKind, RouterStrategyConfig, CascadeClassifierMode, LlmRoutingStrategy, VaultBackend (and more)
• zeph-context: AssemblerError, CompactionTier, CompactionOutcome (context crate, separate from agent-context), PageType
• zeph-db: DbError
• zeph-experiments: ParameterKind, VariationValue, ExperimentSource
• zeph-index: IndexError
• zeph-llm: AnyProvider, ModelSource, ChatTemplate, Role, MessagePart, ToolSseEvent
• zeph-mcp: McpErrorCode
• zeph-orchestration: TaskClass, TopologyHint, TaskStatus, GraphStatus, ExecutionMode, Topology, DispatchStrategy (7 total)
• zeph-skills: SkillSource
• zeph-worktree: WorktreeError

Previously listed enums (zeph-tools, zeph-vault, zeph-core, etc.) remain unresolved.

Full list at HEAD 8ed9fdb available in CI-950 arch audit.

[bug-ops]

CI-951 additions (HEAD b374be4)

The following enums were missed in previous sweeps:

zeph-config/providers.rs

• ThinkingConfig (src/providers.rs:14) — maps to Anthropic API thinking modes; new variants expected as API evolves
• CacheTtl (src/providers.rs:49) — maps to Anthropic cache TTL variants; new TTL options may be added by Anthropic

zeph-experiments/types.rs

• VariationValue (src/types.rs:158) — parameter value type; new variants plausible as experiment parameter types expand (e.g., boolean, categorical). Existed since early PRs, missed in refactor: add #[non_exhaustive] to extensible pub enums in feedback, experiments, plugins, skills, tui #4616 sweep.

All three are extensible pub enums that should carry #[non_exhaustive].

[bug-ops]

Status update — CI-953 (HEAD e8ca5c0)

After batches #4737, #4742, #4744, #4748, the remaining count is:

• 38 files containing pub enums without #[non_exhaustive]
• 50 individual pub enums still missing the attribute

This is down from 99+ filed in CI-949. Still outstanding (sampling):

• zeph-core: AgentError, PipelineError, BootstrapError, TurnExitStatus, CompactionState, GoalStatus + 10 more
• zeph-tools: PolicyDecision, InvocationHint, SandboxError, VerificationResult + 5 more
• zeph-acp: AcpError, LspDiagnosticSeverity, LspSymbolKind
• zeph-orchestration: PlanCommand, PlanCacheError
• zeph-worktree: WorktreeError
• zeph-index: IndexError
• zeph-skills: ScanVerdict

Progress: ~50% complete across the workspace.