Skip to content

fix(cli): make-fastq passes the wrong keyword argument - #13

Merged
bnemoz merged 1 commit into
mainfrom
v2/make-fastq-kwarg
Nov 17, 2026
Merged

bnemoz merged 1 commit into
mainfrom
v2/make-fastq-kwarg

Conversation

@bnemoz

@bnemoz bnemoz commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Problem

pairplex make-fastq called run_make_fastq(sequencing_folder=...), but pairplex.make_fastq.run takes the argument sequence_dir. Every make-fastq call failed with TypeError: run() got an unexpected keyword argument 'sequencing_folder' before basecalling began.

Fix

One line in pairplex/cli/pairplex.py: sequence_dir=sequencing_folder. The CLI argument name and the user-facing interface are unchanged.

Tests

New file pairplex/tests/test_make_fastq.py (subprocess.Popen is mocked, so neither bcl2fastq nor bases2fastq is needed):

  • make-fastq RUN OUT with a SampleSheet.csv in the run folder exits 0 and builds the expected bcl2fastq --runfolder-dir … --output-dir … --sample-sheet … command. On v2-base this test fails with the TypeError above.
  • Every CLI option (--samplesheet, --platform, --debug) is forwarded to make_fastq.run under its real keyword name.

Full suite: 18 passed.

No benchmark: pairplex run is untouched.

Not fixed here (other problems seen in make_fastq.py)

  • If no samplesheet is given or found, csv_samplesheet is never assigned, so the user gets an UnboundLocalError instead of the intended FileNotFoundError.
  • convert_yaml_to_csv compares strings with is (platform is "illumina"), and the YAML builders it calls are placeholders that return None. As a result, YAML samplesheets do not work.

🤖 Generated with Claude Code

The CLI called run_make_fastq(sequencing_folder=...), but
pairplex.make_fastq.run takes sequence_dir, so `pairplex make-fastq`
always failed with TypeError before basecalling started. Add CLI tests
(subprocess mocked).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bnemoz
bnemoz merged commit a8b6376 into main Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant