Repository navigation
fix(cli): make-fastq passes the wrong keyword argument - #13
Merged
Merged
Conversation
The CLI called run_make_fastq(sequencing_folder=...), but pairplex.make_fastq.run takes sequence_dir, so `pairplex make-fastq` always failed with TypeError before basecalling started. Add CLI tests (subprocess mocked). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pairplex make-fastqcalledrun_make_fastq(sequencing_folder=...), butpairplex.make_fastq.runtakes the argumentsequence_dir. Everymake-fastqcall failed withTypeError: run() got an unexpected keyword argument 'sequencing_folder'before basecalling began.Fix
One line in
pairplex/cli/pairplex.py:sequence_dir=sequencing_folder. The CLI argument name and the user-facing interface are unchanged.Tests
New file
pairplex/tests/test_make_fastq.py(subprocess.Popenis mocked, so neither bcl2fastq nor bases2fastq is needed):make-fastq RUN OUTwith aSampleSheet.csvin the run folder exits 0 and builds the expectedbcl2fastq --runfolder-dir … --output-dir … --sample-sheet …command. Onv2-basethis test fails with the TypeError above.--samplesheet,--platform,--debug) is forwarded tomake_fastq.rununder its real keyword name.Full suite: 18 passed.
No benchmark:
pairplex runis untouched.Not fixed here (other problems seen in
make_fastq.py)csv_samplesheetis never assigned, so the user gets anUnboundLocalErrorinstead of the intendedFileNotFoundError.convert_yaml_to_csvcompares strings withis(platform is "illumina"), and the YAML builders it calls are placeholders that returnNone. As a result, YAML samplesheets do not work.🤖 Generated with Claude Code