Repository navigation
test: end-to-end golden-output regression test - #17
Merged
Merged
Conversation
Two simulated wells (<1000 reads each, so one deterministic chunk) run through the real PairPlex + abstar pipeline. Reference behaviour (legacy=True once that flag exists, plain run() before) must equal the stored golden tables: cluster metadata, consensus, pairing decisions and loci exactly; annotation calls exactly only when the installed abstar matches the golden version. The default mode must run and produce well-formed outputs (and honour the pairs/pairs.parquet contract when it writes one). Regenerate with pairplex/tests/data/golden/make_golden.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an end-to-end regression test, so changes to PairPlex can't silently alter the reference output.
What
pairplex/tests/data/golden/input/, 22 KB): two simulated wells with 37 barcodes and about 500 reads each, built from SimPlex output of public paired antibody data.expected/): metadata, consensus, unpaired and paired. They come frommainat a8b6376 (v2-baseplus fix: always pass an explicit mmseqs thread count to abstar.run #12 and fix(cli): make-fastq passes the wrong keyword argument #13, neither of which changes output), with abstar 0.9.0.test_golden.py:run(legacy=True)once the v2 PRs add that flag, and plainrun()until then.pairs/pairs.parquet, the file must have the contract columns.make_golden.py: regenerates the tables and records the commit and abstar version. Use it only for an intended, reviewed change.Verified
min_cluster_reads=5changes metadata, consensus and pairs;clustering_threshold=0.6changes metadata and consensus. Both fail the test.pytest pairplex33 passed.Effect on the open v2 PRs
Each v2 branch adds
legacy=True. Once this test is onmain, CI proves on every PR that legacy mode still reproduces the reference output.🤖 Generated with Claude Code