Skip to content

feat: add semantic line gaps - #287

Merged
brandtnewlabs merged 1 commit into
mainfrom
codex/semantic-line-gaps
Aug 26, 2026
Merged

feat: add semantic line gaps#287
brandtnewlabs merged 1 commit into
mainfrom
codex/semantic-line-gaps

Conversation

@brandtnewlabs

@brandtnewlabs brandtnewlabs commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • add lineGaps with shared renderer-neutral ChartGap* types
  • split line stroke, area/gradient, dot-lattice, and threshold fills across declared gaps, with configurable prior-value bridges, bands, and labels
  • extend scrubbing and tooltips with semantic gap context while letting real samples override gap metadata
  • expand the live Chart gaps demo to switch between moving line and candle charts and showcase bridge, band, label, and color controls
  • document the public API and add focused rendering, path, crosshair, and component coverage

Testing

  • npm run verify — 108 suites passed; 1,622 tests passed, 5 skipped
  • npm run build:lib
  • CI=1 npx react-doctor@latest --verbose --diff — 96/100; only existing/required maintainability warnings
  • agent-device on iPhone 17 Pro simulator — verified moving live line data, raw/semantic/styled treatments, bridge and band toggles, and candle + volume + trade-stream regression; no runtime or worklet errors

Stack

brandtnewlabs commented Aug 21, 2026

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@brandtnewlabs
brandtnewlabs marked this pull request as ready for review August 23, 2026 11:06
@brandtnewlabs
brandtnewlabs deleted the branch main August 26, 2026 07:07
@brandtnewlabs brandtnewlabs reopened this Aug 26, 2026
@brandtnewlabs
brandtnewlabs changed the base branch from codex/semantic-candle-gaps to main August 26, 2026 07:10
@brandtnewlabs
brandtnewlabs force-pushed the codex/semantic-line-gaps branch from 914bf49 to d58975a Compare August 26, 2026 07:10
@brandtnewlabs
brandtnewlabs merged commit 2a9031b into main Aug 26, 2026
6 checks passed
@brandtnewlabs
brandtnewlabs deleted the codex/semantic-line-gaps branch August 26, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant