Add semantic candle gaps and configurable live demo - #286
Merged
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
brandtnewlabs
marked this pull request as ready for review
August 23, 2026 11:05
brandtnewlabs
added a commit
that referenced
this pull request
Aug 26, 2026
## Summary - add `lineGaps` with shared renderer-neutral `ChartGap*` types - split line stroke, area/gradient, dot-lattice, and threshold fills across declared gaps, with configurable prior-value bridges, bands, and labels - extend scrubbing and tooltips with semantic gap context while letting real samples override gap metadata - expand the live Chart gaps demo to switch between moving line and candle charts and showcase bridge, band, label, and color controls - document the public API and add focused rendering, path, crosshair, and component coverage ## Testing - `npm run verify` — 108 suites passed; 1,622 tests passed, 5 skipped - `npm run build:lib` - `CI=1 npx react-doctor@latest --verbose --diff` — 96/100; only existing/required maintainability warnings - agent-device on iPhone 17 Pro simulator — verified moving live line data, raw/semantic/styled treatments, bridge and band toggles, and candle + volume + trade-stream regression; no runtime or worklet errors ## Stack - depends on #286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-trades,unavailable, andunknowncandle-gap metadata without synthesizing OHLC recordsbridge,band, andlabelstyles, including theme fallbacks and per-section enable/disable behaviorVerification
npm run verify— 107 suites passed; 1,611 tests passed; 5 skippednpm run build:lib