Repository navigation
Conversation
commit: |
Collaborator
|
superceded by #26 |
cowboyd
force-pushed
the
improve-types-delta-fold
branch
from
September 9, 2026 01:21
1e44350 to
cffe20b
Compare
Collaborator
|
brought in with #26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Maintaining type overloads isn't a great experience and we have a few more type tools to work with in more recent versions of TypeScript.
Approach
Some conditionals, extends and "variadic tuple" types get the job done. The types are "smaller" but more advanced. The error shape and IDE "look and feel" change. I think we have trade offs in each, but this does scale much further without having to consider adding more overloads. Depending on how our constraints change as we finalize everything may push us towards one set of trade offs vs another.