Fix queried settings persistence and recover failed RAM jobs - #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the confirmed MintPrint Settings regression reported in #91 and makes failed RAM-spooled graphics jobs recoverable.
Query -> Save persistence
The AmigaOS 2.x compatibility change removed the V39-only
GT_GetGadgetAttrs()reads from Save and correctly moved Cycle tracking toIDCMP_GADGETUP. However, Query Printer updates Cycle gadgets programmatically withGT_SetGadgetAttrs(), which does not emitGADGETUP. The window could therefore display valid defaults while Save wrote blank/staleMEDIA=,SOURCE=,COLOR=,QUALITY=orSCALING=values.This change keeps the V37-compatible event model and explicitly synchronises each queried/programmatic selection with its persisted backing value. Existing saved choices are preserved when still supported; otherwise the exact visible safe default is saved.
RAM Spooler visibility and recovery
RAM/T: jobs now receive a status sidecar:
T:when RAM is selected.The driver revision moves from 41.16 to 41.17 so Settings can detect and offer the corrected driver.
Scope
This does not claim to fix the separate 36-page interrupted-transfer report without first identifying its logged failure code. Retaining the failed RAM document/status makes that case diagnosable and retryable instead of destroying the evidence.
Test plan
make check— GitHub Actions CI run #161 passed.Fixes #91