Skip to content

[PM-40544] Default trial-initiation length to 14 days #8810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbrown-livefront wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −3
Open

[PM-40544] Default trial-initiation length to 14 days #8810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
823cca3
feat(billing): default trial-initiation length to 14 days
sbrown-livefront Oct 29, 2026
0e04f5d
Merge branch 'main' into billing/pm-40544/update-default-trial-length
sbrown-livefront Nov 4, 2026
8020c75
fix(billing): default sales-assisted trial invitation length to 14 days
sbrown-livefront Nov 6, 2026
45da471
Merge branch 'main' into billing/pm-40544/update-default-trial-length
sbrown-livefront Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Admin/Auth/Controllers/SalesAssistedTrialController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using Bit.Admin.Auth.Models.SalesAssistedTrial;
using Bit.Admin.Enums;
using Bit.Admin.Utilities;
using Bit.Core.Billing.Constants;
using Bit.Core.Billing.Enums;
using Bit.Core.Billing.TrialInitiation.Registration;
using Bit.Core.Exceptions;
Expand Down Expand Up @@ -36,7 +37,7 @@ public IActionResult Index()
{
ProductTier = ProductTierType.Enterprise,
Products = [ProductType.PasswordManager],
TrialLength = 30
TrialLength = TrialInitiationConstants.DefaultTrialLengthDays
});
}

Expand Down
2 changes: 1 addition & 1 deletion src/Core/Billing/Constants/TrialInitiationConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

public static class TrialInitiationConstants
{
public const int DefaultTrialLengthDays = 7;
public const int DefaultTrialLengthDays = 14;
}
3 changes: 2 additions & 1 deletion test/Admin.Test/Auth/Controllers/SalesAssistedTrialControllerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.Security.Claims;
using Bit.Admin.Auth.Controllers;
using Bit.Admin.Auth.Models.SalesAssistedTrial;
using Bit.Core.Billing.Constants;
using Bit.Core.Billing.Enums;
using Bit.Core.Billing.TrialInitiation.Registration;
using Bit.Core.Exceptions;
Expand Down Expand Up @@ -53,7 +54,7 @@ public void Index_Get_ReturnsViewWithSensibleDefaults(
var model = Assert.IsType<SalesAssistedTrialInviteModel>(viewResult.Model);
Assert.Equal(ProductTierType.Enterprise, model.ProductTier);
Assert.Equal([ProductType.PasswordManager], model.Products);
Assert.Equal(30, model.TrialLength);
Assert.Equal(TrialInitiationConstants.DefaultTrialLengthDays, model.TrialLength);
}

[Theory, BitAutoData]
Expand Down
Loading