Skip to content

[PM-40544] Default trial-initiation length to 14 days - #8810

Open
sbrown-livefront wants to merge 4 commits into
mainfrom
billing/pm-40544/update-default-trial-length
Open

sbrown-livefront wants to merge 4 commits into
mainfrom
billing/pm-40544/update-default-trial-length

Conversation

@sbrown-livefront

@sbrown-livefront sbrown-livefront commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-40544
https://bitwarden.atlassian.net/browse/PM-46435

📔 Objective

Updates the default trial length for the trial-initiation flow from 7 to 14 days, to match the new standard for sales-initiated and marketing trials. TrialInitiationConstants.DefaultTrialLengthDays is the fallback the accounts/trial/send-verification-email endpoint uses when a request does not specify a trial length.

Also fixes PM-46435: the Admin Portal Send Sales-Assisted Trial Invitation form pre-filled Trial Length (Days) with a hard-coded 30, so sales-assisted invitations never picked up the 14-day default. The form's initial-GET default now uses TrialInitiationConstants.DefaultTrialLengthDays. Explicit lengths entered by a sales user still pass through unchanged.

@sbrown-livefront sbrown-livefront added the ai-review Request a Claude code review label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR raises TrialInitiationConstants.DefaultTrialLengthDays from 7 to 14. It also points the default on the Admin sales-assisted trial invite form (SalesAssistedTrialController.Index GET) at that constant, which lowers the pre-filled value there from 30 to 14 days. The only other consumer of the constant is the null fallback in Identity/Billing/Controller/AccountsController, and 14 stays inside the existing trial-length validation bounds on both paths. The POST path still uses whatever length the user submits, and the Admin and Identity tests assert against the constant rather than a hard-coded number, so they pick up the new value.

@sbrown-livefront sbrown-livefront self-assigned this Nov 4, 2026
@sbrown-livefront sbrown-livefront added the t:feature Change Type - Feature Development label Nov 4, 2026
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.48%. Comparing base (6f35199) to head (45da471).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8810   +/-   ##
=======================================
  Coverage   68.48%   68.48%           
=======================================
  Files        2750     2750           
  Lines      117618   117618           
  Branches    10781    10781           
=======================================
  Hits        80554    80554           
  Misses      34524    34524           
  Partials     2540     2540           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sbrown-livefront sbrown-livefront changed the title [PM-40544] feat: default trial-initiation length to 14 days [PM-40544] Default trial-initiation length to 14 days Nov 4, 2026
@sbrown-livefront
sbrown-livefront marked this pull request as ready for review November 4, 2026 19:05
@sbrown-livefront
sbrown-livefront requested a review from a team as a code owner November 4, 2026 19:05
kdenney
kdenney previously approved these changes Nov 4, 2026
@bre-deploy
bre-deploy Bot deployed to US-QA2 Cloud November 5, 2026 18:13 Active

This branch was successfully deployed

1 active (outdated) deployment
US-QA2 Cloud — 0e04f5d4 Deployed Nov 5, 2026 by bre-deploy[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants