ci: add the missing lint gate, and put typecheck in verify - #2
Merged
Conversation
Same two gaps as ai-forms (fixed there in #11), from the same scaffold: - No lint at all. ESLint was not a dependency, there was no config, and no script referenced it — so the fleet verify floor (lint AND typecheck AND test) was unmet. - `typecheck` existed but was not in `verify`. `build` is `tsc -p`, so types were checked only as a side effect of emitting. That conflates "compiles to dist" with "types are sound", and it evaporates the moment the build strategy changes. verify = lint → typecheck → build → test. Recommended presets only. This is ~600 lines of library code; a bespoke rule set would be a second opinion to maintain for no benefit. The floor is "lint runs and can fail", not "lint encodes taste". Lint is clean on arrival, so this closes a hole rather than deferring a backlog. CI needs no change — ci.yml already calls `npm run verify` verbatim. Verified: `npm run verify` passes — eslint clean, tsc clean, build clean, 31/31 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same two gaps as ai-forms (#11), from the same scaffold:
typecheckexisted but was not inverify.buildistsc -p, so types were checked only as a side effect of emitting. That conflates "compiles to dist" with "types are sound", and it evaporates the moment the build strategy changes.verify= lint → typecheck → build → test.Recommended presets only — ~600 lines of library code doesn't need a bespoke rule set, which would just be a second opinion to maintain. Lint is clean on arrival, so this closes a hole rather than deferring a backlog.
CI needs no change:
ci.ymlalready callsnpm run verifyverbatim.Verified:
npm run verifypasses — eslint clean, tsc clean, build clean, 31/31 tests.🤖 Generated with Claude Code