ci: add the missing lint gate, and put typecheck in verify - #4
Merged
Conversation
Third instance of one scaffold defect. ai-forms (#11) and ai-ration (#2) had exactly this, and so does threadkit: - No lint at all. ESLint was not a dependency, there was no config, and no script referenced it — so the fleet verify floor (lint AND typecheck AND test) was unmet. - `typecheck` existed but was not in `verify`. `build` is `tsc -p`, so types were checked only as a side effect of emitting. That conflates "compiles to dist" with "types are sound", and it evaporates the moment the build strategy changes. verify = lint → typecheck → build → test. Three repos with the same gap is a template problem, not three coincidences. The instance is fixed here; the generator that produces `"verify": "npm run build && npm test"` needs the same edit, or repo four is born with it. Naming that explicitly rather than quietly fixing instance three — an un-encoded "I'll remember" is the thing the never-twice rule exists to prevent. Recommended presets only. ~500 lines of library code does not need a bespoke rule set. Lint is clean on arrival, so this closes a hole rather than deferring a backlog. CI needs no change — ci.yml already calls `npm run verify` verbatim. Verified: `npm run verify` passes — eslint clean, tsc clean, build clean, 31/31 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third instance of one scaffold defect. ai-forms (#11) and ai-ration (#2) had exactly this, and so does threadkit:
typecheckexisted but was not inverify.buildistsc -p, so types were checked only as a side effect of emitting. That conflates "compiles to dist" with "types are sound", and it evaporates the moment the build strategy changes.verify= lint → typecheck → build → test.The part worth acting on
Three repos with the same gap is a template problem, not three coincidences. The instance is fixed here; whatever generates
"verify": "npm run build && npm test"needs the same edit, or repo four is born with it.Naming that explicitly rather than quietly fixing instance three — an un-encoded "I'll remember" is exactly what the never-twice rule exists to prevent.
Verification
Recommended presets only; ~500 lines of library code doesn't need a bespoke rule set. Lint is clean on arrival, so this closes a hole rather than deferring a backlog.
npm run verifypasses — eslint clean, tsc clean, build clean, 31/31 tests. CI needs no change;ci.ymlalready callsnpm run verifyverbatim.🤖 Generated with Claude Code