Skip to content

Added flake support - #167

Merged
bilalyazicioglu merged 7 commits into
bilalyazicioglu:developfrom
Melal1:main
Oct 4, 2026
Merged

bilalyazicioglu merged 7 commits into
bilalyazicioglu:developfrom
Melal1:main

Conversation

@Melal1

@Melal1 Melal1 commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Description

Added nix/flake support , currently only x86_64linux because this is only the one I tested but it should work on others

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have run cargo test and all 93+ tests pass cleanly.
  • I have run cargo clippy --all-targets and resolved all warnings.
  • I have formatted my code with cargo fmt.
  • I have updated relevant documentation / Wiki files.

Copilot AI balanced review requested due to automatic review settings October 4, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Missing executable metadata makes nix run select a nonexistent binary.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Adds Nix flake support for building and installing tincan on x86_64 Linux.

Changes:

  • Defines a Rust package with audio dependencies.
  • Exposes a default package and overlay with a pinned nixpkgs input.
  • Documents Nix shell, profile, and NixOS usage.
File Description
README.md Documents Nix installation and integration.
flake.nix Exposes the default package and overlay.
flake.lock Pins the nixpkgs dependency.
default.nix Defines the Rust build and native dependencies.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread default.nix
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@bilalyazicioglu
bilalyazicioglu changed the base branch from main to develop October 4, 2026 16:42
@bilalyazicioglu

Copy link
Copy Markdown
Owner

Thanks a lot for this, Nix support is very welcome!

I've retargeted the PR to develop, which is where all PRs land; main only gets releases. A few small things before merging:

  1. version = "0.3.3" will go stale with every release. version = (lib.importTOML ./Cargo.toml).package.version; keeps it in sync.
  2. alsa-lib is Linux-only. With buildInputs = [ libopus ] ++ lib.optionals stdenv.isLinux [ alsa-lib ]; we could list aarch64-linux (and probably the Darwin systems) too. Fine to leave them untested, or I can try macOS.
  3. Could you add the rest of meta next to mainProgram: description, homepage = "https://tincan.rs", license = lib.licenses.mit?
  4. The README section could be shorter, to match the others: the two nix commands plus a line pointing to flake.nix for the overlay.

@Melal1

Melal1 commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for your reply , I am really a beginner and new to PR's .
I am working on this now .

@bilalyazicioglu
bilalyazicioglu self-requested a review October 4, 2026 16:52
@bilalyazicioglu
bilalyazicioglu merged commit 6f080aa into bilalyazicioglu:develop Oct 4, 2026
5 checks passed
@bilalyazicioglu bilalyazicioglu mentioned this pull request Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants