Multi-press support#24264
Open
ickshonpe wants to merge 3 commits into
Open
Conversation
This is to allow click then press and drag actions. Text inputs no long observe `Click` events, instead they check `count` on press.
… if we update the click count on presses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The text input widget selects the word under the pointer on a double click. This isn't correct, the select word edit should be queued on the press following a click. This allows for users to select a word with a double press and then hold the button and drag to extend the selection.
Solution
Track multi-presses as well as multi-clicks:
countfield toPressevents.PointerButtonState::clickingon consecutive presses within the multi-click duration, not on releases.clickingmap in both thePressandClickdispatchers.Testing
You should observe that dragging after selecting a word with a double press extends the selection.
It's still not quite right as the selection is extended from the point in the word that was clicked, not the word itself. This is a bug in Parley revealed by this change.