Extract between non-main sub-apps#24259
Draft
therealbnut wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This is work in progress, just intended to show a general approach. It's a small extension on the existing
SubApp::{extract, set_extract, take_extract}methods to have labelled versions of them. This allows for extraction between SubApps that aren't main.One issue with this currently is it does not allow a deterministic order between the apps, which may mean you can't construct a DAG of extractions between subapps. This could be solved by storing the labels vector from
SubApps::update, but that needs further thought.This is mainly to provide to context when asking whether the general approach of adding more extract methods to SubApps would be accepted, or if it would still be blocked by the greater multi-world work.
Related issues:
Solution
Testing
Showcase
While a showcase should aim to be brief and digestible, you can use a toggleable section to save space on longer showcases:
Click to view showcase