Don't remove Handle tracking upon soft-removal of an asset.#24251
Open
larsraph wants to merge 1 commit into
Open
Don't remove Handle tracking upon soft-removal of an asset.#24251larsraph wants to merge 1 commit into
larsraph wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error
I believe the intended behavior of
removeandremove_untrackedis for the backing Id to still be valid until all handles are dropped however theremove_untracked(called byremove) drops the Handle refcount (calledduplicate_handles) for that id.This is illogically sound because we're still using the refcount to track the handles. But it technically has the same result IF we only have a single live handle (surely like 90% of use cases) because the refcount only gets checked on a dropped Handle.
@andriyDev - If you wanted to look into this.