Skip to content

fixed spotlight shadow issue due to incorrect basis reconstruction #24238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeroenHoogers wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −11
Open

fixed spotlight shadow issue due to incorrect basis reconstruction #24238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56838c1
fixed spotlight shadow issue due to incorrect matrix reconstruction
JeroenHoogers May 10, 2026
10a0cbe
replaced basis calculation in volumetric fog code with a call to math…
JeroenHoogers May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions crates/bevy_pbr/src/volumetric_fog/volumetric_fog.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
position_ndc_to_world,
position_view_to_world
}
#import bevy_render::maths::orthonormalize
#import bevy_pbr::clustered_forward as clustering
#import bevy_pbr::lighting::getDistanceAttenuation;

Expand Down Expand Up @@ -478,17 +479,7 @@ fn fetch_spot_shadow_without_normal(light_id: u32, frag_position: vec4<f32>, fra
-surface_to_light
+ ((*light).shadow_depth_bias * normalize(surface_to_light));

// the construction of the up and right vectors needs to precisely mirror the code
// in render/light.rs:spot_light_view_matrix
var sign = -1.0;
if (fwd.z >= 0.0) {
sign = 1.0;
}
let a = -1.0 / (fwd.z + sign);
let b = fwd.x * fwd.y * a;
let up_dir = vec3<f32>(1.0 + sign * fwd.x * fwd.x * a, sign * b, -sign * fwd.x);
let right_dir = vec3<f32>(-b, -sign - fwd.y * fwd.y * a, fwd.y);
let light_inv_rot = mat3x3<f32>(right_dir, up_dir, fwd);
let light_inv_rot = orthonormalize(fwd);

// because the matrix is a pure rotation matrix, the inverse is just the transpose, and to calculate
// the product of the transpose with a vector we can just post-multiply instead of pre-multiplying.
Expand Down
Loading