Pack the serivce into docker image - #341
duchenpaul wants to merge 1 commit into
Conversation
|
Hi @duchenpaul! As I don't personally use and also could not support docker: Do you want to maintain / support docker for the bepasty project? I'm sure some users might have questions or the code might need future changes or fixes. Cheers, Thomas |
|
Also: is this superseding #262? |
Yes, I would like to support and maintain the docker aspect of this project. If you don't use docker, I will remove the dockerhub part as that would need your dockerhub account to deploy the images. And for your another question, that would also be yes. |
|
I removed the part that upload to dockerhub. |
ThomasWaldmann
left a comment
ThomasWaldmann
left a comment
There was a problem hiding this comment.
thanks for the PR, here some stuff i found...
| file: ./docker/Dockerfile | ||
| push: true | ||
| tags: | | ||
| ghcr.io/${{ github.repository }}:1.2.2 |
There was a problem hiding this comment.
hardcoded version number.
|
Hey, I finally got chance to fix this. |
|
Could you please do a clean rebase on current master, so it is just one commit and no merges? |
Done |
|
|
||
| - name: Extract metadata (tags, labels) for Docker | ||
| id: meta | ||
| uses: docker/metadata-action@9ec57ed1fcdbf14dcef7dfbe97b2010124a938b7 |
There was a problem hiding this comment.
that is from 2023 - use @v6 or equivalent please.
ThomasWaldmann
left a comment
ThomasWaldmann
left a comment
There was a problem hiding this comment.
some other small findings, fix them if you like.
| if "BEPASTY_STORAGE_FILESYSTEM_DIRECTORY" in os.environ: | ||
| STORAGE_FILESYSTEM_DIRECTORY = os.environ["BEPASTY_STORAGE_FILESYSTEM_DIRECTORY"] |
There was a problem hiding this comment.
you could also use .get here, for better consistency.
2 participants
Also add pipeline to push to dockerhub and ghcr