Skip to content

Pack the serivce into docker image. - #352

Open
duchenpaul wants to merge 1 commit into
bepasty:masterfrom
duchenpaul:image_fix
Open

Pack the serivce into docker image.#352
duchenpaul wants to merge 1 commit into
bepasty:masterfrom
duchenpaul:image_fix

Conversation

@duchenpaul

@duchenpaul duchenpaul commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Also add pipeline to push to dockerhub and ghcr

@duchenpaul
duchenpaul marked this pull request as ready for review July 29, 2026 08:44
@duchenpaul

duchenpaul commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Follow PR #341

ThomasWaldmann
ThomasWaldmann reviewed Jul 29, 2026
View reviewed changes

@ThomasWaldmann ThomasWaldmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the old commit hash.

Comment thread .github/workflows/dockerhub.yml Outdated
ThomasWaldmann
ThomasWaldmann approved these changes Jul 29, 2026
View reviewed changes

@ThomasWaldmann ThomasWaldmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I assume you have tested the docker image resulting from the current code?

@ThomasWaldmann

ThomasWaldmann commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

There is also #262 - can you have a look please, is your PR superseding this?

@duchenpaul
duchenpaul force-pushed the image_fix branch 4 times, most recently from 36081c1 to 658560c Compare July 30, 2026 15:11
@duchenpaul

duchenpaul commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Looks good.

I assume you have tested the docker image resulting from the current code?

I added hadolint and dgoss to lint and test dockerfiles

@duchenpaul

duchenpaul commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

There is also #262 - can you have a look please, is your PR superseding this?

Yes, we can close that after this PR merged, this is based on that one.

ThomasWaldmann
ThomasWaldmann requested changes Jul 31, 2026
View reviewed changes

@ThomasWaldmann ThomasWaldmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a clean rebase on current master, 1 commit only.

@duchenpaul

duchenpaul commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Done

ThomasWaldmann
ThomasWaldmann reviewed Aug 1, 2026
View reviewed changes

@ThomasWaldmann ThomasWaldmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stuff I wondered about.

Comment thread .github/workflows/ci.yml Outdated
Comment thread docker/goss.yaml
Comment thread .github/workflows/dockerhub.yml
@duchenpaul

duchenpaul commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

@ThomasWaldmann Possible to get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomasWaldmann ThomasWaldmann Awaiting requested review from ThomasWaldmann

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@duchenpaul @ThomasWaldmann