Skip to content

feat(ui): added renewal badge to old and new examiner dashboards #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JazzarKarim merged 6 commits into from
Feb 24, 2026
Merged

feat(ui): added renewal badge to old and new examiner dashboards #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
79347c2
feat(ui): added renewal badge to old and new examiner dashboards
JazzarKarim Feb 20, 2026
0b9cadb
fixed SC issue
JazzarKarim Feb 20, 2026
2851c50
added comment
JazzarKarim Feb 20, 2026
22055cd
fixed comment
JazzarKarim Feb 20, 2026
ddb403a
changed to show which registrations has been renewed
JazzarKarim Feb 23, 2026
08f9676
added PROVISIONAL_REVIEW to enum
JazzarKarim Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 42 additions & 5 deletions strr-examiner-web/app/pages/dashboard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,25 @@ const getRequirementsColumn = (app: HousApplicationResponse) => {
return result
}

/** Application statuses that mean a renewal was completed (registration was renewed) */
const RENEWAL_APPROVED_STATUSES = new Set<ApplicationStatus>([
ApplicationStatus.FULL_REVIEW_APPROVED,
ApplicationStatus.PROVISIONALLY_APPROVED,
Copy link
Collaborator Author

@JazzarKarim JazzarKarim Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just waiting on Victor's reply to see if I should add ApplicationStatus.PROVISIONAL_REVIEW as well.

Copy link
Collaborator Author

@JazzarKarim JazzarKarim Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revisit this in another PR once I receive an answer from Victor.

ApplicationStatus.PROVISIONAL_REVIEW,
ApplicationStatus.AUTO_APPROVED
])

/** Check if a registration has been renewed. Draft renewals are ignored (Renewals in progress). */
const hasBeenRenewed = (reg: HousRegistrationResponse): boolean => {
const applications = reg.header?.applications ?? []
return applications.some(
app =>
app.applicationType === 'renewal' &&
app.applicationStatus &&
RENEWAL_APPROVED_STATUSES.has(app.applicationStatus as ApplicationStatus)
)
}

const getConditionsColumnForRegistration = (reg: HousRegistrationResponse) => {
let result = ''
let listingSize = ''
Expand Down Expand Up @@ -385,7 +404,8 @@ const { data: registrationListResp, status: regStatus } = await useAsyncData(
applicantName: getApplicantNameColumnForRegistration(reg),
propertyAddress: getPropertyAddressColumnForRegistration(reg),
localGov: '', // TODO: implement this once API has made the changes
adjudicator: getAdjudicatorColumn(reg.header)
adjudicator: getAdjudicatorColumn(reg.header),
hasRenewed: hasBeenRenewed(reg)
}))

return { registrations, total: res.total }
Expand Down Expand Up @@ -428,6 +448,7 @@ const { data: applicationListResp, status } = await useAsyncData(
applicationNumber: app.header.applicationNumber,
registrationNumber: app.header.registrationNumber,
registrationId: app.header.registrationId,
applicationType: app.header?.applicationType,
registrationType: t(`registrationType.${app.registration.registrationType}`),
requirements: getRequirementsColumn(app),
applicantName: getApplicantNameColumn(app),
Expand Down Expand Up @@ -915,8 +936,16 @@ const tabLinks = computed(() => [
<div v-if="isApplicationTab">
{{ row.applicationNumber }}
</div>
<div v-else>
{{ row.registrationNumber }}
<div v-else class="flex flex-col">
<span>{{ row.registrationNumber }}</span>
<UBadge
v-if="row.hasRenewed"
:label="t('label.renewal')"
color="primary"
variant="solid"
class="mt-1 w-fit text-xs font-bold uppercase"
data-testid="renewal-badge"
/>
</div>
<UButton
v-if="row.registrationNumber && isApplicationTab"
Expand All @@ -930,8 +959,8 @@ const tabLinks = computed(() => [
{{ row.registrationNumber }}
</UButton>
</div>
<div v-else>
{{ row.applicationNumber }}
<div v-else class="flex flex-col">
<span>{{ row.applicationNumber }}</span>
<UButton
v-if="row.registrationNumber"
icon="i-mdi-check-circle"
Expand All @@ -943,6 +972,14 @@ const tabLinks = computed(() => [
>
{{ row.registrationNumber }}
</UButton>
<UBadge
v-if="row.applicationType === 'renewal'"
:label="t('label.renewal')"
color="primary"
variant="solid"
class="mt-1 w-fit text-xs font-bold uppercase"
data-testid="renewal-badge"
/>
</div>
</template>

Expand Down
2 changes: 1 addition & 1 deletion strr-examiner-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "strr-examiner-web",
"private": true,
"type": "module",
"version": "0.2.16",
"version": "0.2.17",
"scripts": {
"build-check": "nuxt build",
"build": "nuxt generate",
Expand Down
Loading