feat(ui): added renewal badge to old and new examiner dashboards#1042
feat(ui): added renewal badge to old and new examiner dashboards#1042JazzarKarim merged 6 commits intobcgov:mainfrom
Conversation
| const hasRenewalInProgress = (reg: HousRegistrationResponse): boolean => { | ||
| const applications = reg.header?.applications ?? [] | ||
| return applications.some( | ||
| app => | ||
| app.applicationType === 'renewal' && | ||
| app.applicationStatus && | ||
| !RENEWAL_NOT_IN_PROGRESS_STATUSES.has(app.applicationStatus as ApplicationStatus) |
There was a problem hiding this comment.
Dima, let me know your thoughts about this solution.
Basically, we check if application type is renewal. If it is and the status is not one of those 5 above, that means it's a renewal that is in progress.
There was a problem hiding this comment.
So the requirement was to show Renewals in progress?
I thought they wanted to see which Registration is a Renewal, to distinguish it from the first-ever Registrations.
There was a problem hiding this comment.
Dima, thanks for catching this. So I confirmed with Victor, you're absolutely right. Examiners want to see when a registration has been renewed.
I made that change and it should look good now.
|
Temporary Url for review: https://strr-examiner-dev--pr-1042-upadrz7n.web.app |
JazzarKarim
force-pushed
the
32523-renewal-badge-update
branch
from
12c0494 to
ddb403a
Compare
| /** Application statuses that mean a renewal was completed (registration was renewed) */ | ||
| const RENEWAL_APPROVED_STATUSES = new Set<ApplicationStatus>([ | ||
| ApplicationStatus.FULL_REVIEW_APPROVED, | ||
| ApplicationStatus.PROVISIONALLY_APPROVED, |
There was a problem hiding this comment.
I'm just waiting on Victor's reply to see if I should add ApplicationStatus.PROVISIONAL_REVIEW as well.
There was a problem hiding this comment.
Will revisit this in another PR once I receive an answer from Victor.
|
Temporary Url for review: https://strr-examiner-dev--pr-1042-upadrz7n.web.app |
|
|
Temporary Url for review: https://strr-examiner-dev--pr-1042-upadrz7n.web.app |
3 participants
Issue:
Description of changes:
Old dashboard:
New dashboard:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License