Skip to content

fix(disputegamefactory): apply CEI pattern in create() and createWithInitData() #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dev-khimesh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(disputegamefactory): apply CEI pattern in create() and createWithInitData() #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/L1/proofs/DisputeGameFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,10 @@ contract DisputeGameFactory is ProxyAdminOwnedBase, ReinitializableBase, Ownable
returns (IDisputeGame proxy_)
{
proxy_ = _createGameImpl(_gameType, _rootClaim, _extraData);
proxy_.initialize{ value: msg.value }();
// EFFECT: Finalize and register state first (CEI pattern)
_finalizeGameCreation(_gameType, _rootClaim, _extraData, proxy_);
// INTERACTION: Perform external initialization call last
proxy_.initialize{ value: msg.value }();
}

function createWithInitData(
Expand All @@ -165,8 +167,10 @@ contract DisputeGameFactory is ProxyAdminOwnedBase, ReinitializableBase, Ownable
returns (IDisputeGame proxy_)
{
proxy_ = _createGameImpl(_gameType, _rootClaim, _extraData);
proxy_.initializeWithInitData{ value: msg.value }(_initData);
// EFFECT: Finalize and register state first (CEI pattern)
_finalizeGameCreation(_gameType, _rootClaim, _extraData, proxy_);
// INTERACTION: Perform external initialization call last
proxy_.initializeWithInitData{ value: msg.value }(_initData);
}

/// @notice Creates a new DisputeGame proxy contract.
Expand Down