Skip to content

fix(l2genesis): correct WETH initialization docs in setWETH() #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dev-khimesh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(l2genesis): correct WETH initialization docs in setWETH() #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/L2Genesis.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,15 @@ contract L2Genesis is Script {
}

/// @notice This predeploy is following the safety invariant #1.
/// This contract is NOT proxied and the state that is set
/// in the constructor is set manually.
/// This contract is NOT proxied. vm.getDeployedCode with vm.etch is used
/// because WETH98 has no immutables and no constructor-side effects.
/// decimals is a constant (compiled into bytecode), name/symbol are
/// pure/virtual functions, and the only storage slots are _balanceOf
/// (slot 0) and _allowance (slot 1) mappings which correctly start empty.
function setWETH() internal {
vm.etch(Predeploys.WETH, vm.getDeployedCode("WETH.sol:WETH"));
// WETH98 uses constants and pure functions for name/symbol/decimals,
// so there are no constructor-side effects to reinitialize via vm.store.
}

/// @notice This predeploy is following the safety invariant #2.
Expand Down