fix(l2genesis): correct WETH initialization docs in setWETH()#369
Open
dev-khimesh wants to merge 1 commit into
Open
fix(l2genesis): correct WETH initialization docs in setWETH()#369dev-khimesh wants to merge 1 commit into
dev-khimesh wants to merge 1 commit into
Conversation
Updates NatSpec comment on setWETH() to accurately reflect WETH98 uses constants and pure functions with no constructor-side effects. Closes base#357.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the NatSpec comment on
setWETH()inL2Genesis.s.solto accurately reflect that WETH98 uses constants and pure functions forname/symbol/decimals, so there are no constructor-side effects to reinitialize viavm.store. The contract follows safety invariant #1 as there are no immutables or constructor-side effects.Changes
setWETH()comment to reflect actual contract behaviorCloses #357