[codex] Fix remote semantic status reporting and Windows path tests#98
Draft
PROJECT-OCULUS wants to merge 1 commit intobartolli:mainfrom
Draft
[codex] Fix remote semantic status reporting and Windows path tests#98PROJECT-OCULUS wants to merge 1 commit intobartolli:mainfrom
PROJECT-OCULUS wants to merge 1 commit intobartolli:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two related
v0.9.18issues around remote semantic indexing status/reporting, and also hardens a few Windows-sensitive tests that were failing because of non-portable fixtures.The runtime fixes make
mcp get_index_inforeport persisted remote semantic metadata correctly afterindex-parallel, and ensureindex-parallelpersists normal index metadata so a follow-up MCP status read does not trigger an unnecessary sync/reindex on stderr.The test fixes are limited to portability: they replace Unix-only path assumptions and TOML string escaping pitfalls in a few parser tests without changing production parser behavior.
Changes
Remote semantic status and metadata
mcp get_index_inforeport persisted remote semantic metadata instead of incorrectly claiming semantic search is disabled.index.metaafterindex-parallel, including indexed paths, so the next MCP status call does not perform a compensating sync.Windows test portability
Settingssetup so Windows paths do not break TOML parsing.Why
On
v0.9.18, a remote semantic index could be successfully created on disk while:mcp get_index_info --jsonstill reportedsemantic_search.enabled = falseindex-parallelcould emit indexing/progress noise onstderrbecauseindex.metahad not been persistedSeparately, three tests were failing on Windows because they used Unix-only path fixtures or inserted raw Windows paths into TOML basic strings.
Verification
Passed targeted checks:
cargo test test_load_facade_lite_preserves_semantic_metadata_snapshot -- --nocapturecargo test mcp_get_index_info_reports_remote_semantic_status_and_model -- --nocapturecargo test parsing::java::behavior::tests::test_module_path_from_file_uses_provider -- --nocapturecargo test parsing::lua::behavior::tests::test_module_path_from_file -- --nocapturecargo test parsing::paths::tests::test_normalize_relative_path -- --nocapturecargo test parsing::paths::tests::test_normalize_absolute_path -- --nocapturecargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningsLive validation:
snowflake-arctic-embed:latestindex-parallelreportedbackend: remote, model: snowflake-arctic-embed:latestmcp get_index_info --jsonreported semantic search enabled with the persisted remote modelKnown limitation
cargo testis still not fully green becausetests/parsers/typescript/test_pipeline_resolution.rs::test_behavior_pipeline_cache_isolatedalready fails on clean upstream236b402. That failure reproduces in a clean worktree at the exact upstream commit, so it is not introduced by this patch.Notes for reviewers
.github/contains workflow files only.contributing/parsers/*document churn so the diff stays reviewable.