Repository navigation
mu B3: analyze cache guard + CleanTarget.roots - #5
Merged
Merged
Conversation
A scan that bypasses the cache (--json) never reads it, so writing the result was pure waste: a --json run of a big tree paid a full serialize+fsync+rename for a file nothing would open. The walker now skips the save whenever bypass_cache is set; a warm TUI run still loads from cache, and R still invalidates then rescans and saves. Payloads are also bounded by MAX_CACHE_BYTES (64 MiB) before the rename, so scanning $HOME or / cannot dump hundreds of MB into $XDG_CACHE_HOME/mu/analyze. An oversized payload is a silent no-op (Ok(None), no output, no exit-code change) and an oversized file left by an older build is dropped on load as a miss.
…an_target_roots - Add roots: Vec<PathBuf> field to CleanTarget - Populate roots in all target constructors from existing bound paths - Derive clean_target_roots_in from all_targets_in(deps) flat_map roots - Remove parallel hardcoded root enumeration in clean_target_roots_in - Add equality and badge equivalence characterization tests against legacy roots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B3 items 1-2:
Verify: make test 473 unit + 59 integration pass; make lint clean.
from therealTINHTUTE with love ❤️❤️❤️