Repository navigation
B4: analyze TUI parity with upstream mo analyze - #6
Merged
Merged
Conversation
Triaged every open LOW/inherited finding; fixes carry a test that fails on the previous code. - purge/installer: a TTY cancel is no longer reported as "Non-interactive". `select_indices` returns a `SelectOutcome` (Confirmed/Cancelled/ NonInteractive/Unavailable) and one `resolve` decides the message and exit code, so the three "nothing deleted" paths cannot be conflated again (p4r1#1). - status: `read_disk_io_from_with_sysfs` takes the sysfs root, so the partition/dm- filter is provable from a fixture instead of the host's /sys/class/block (p5r1#2). The public `read_disk_io_from` is unchanged. - tui menu: the biometrics and update rows are resolved once in `MainMenu::new` (`MenuStatus::load_from`), not on every frame (p6r1#10). - purge/installer: exit nonzero when every deletion failed (rvp4#6). - optimize: SQLite sidecars are matched as `<db>-wal`/`<db>-journal`, which Chrome's extension-less databases need (rvp3#11). - tui whitelist: RAII guards restore the terminal on the error paths (rvp6#11). - tests: the stale-state sentinel is 40 days old in a temp XDG_STATE_HOME, so the test can detect the bug it guards (rvp3#9); the status JSON integration test no longer requires host-optional fields (rvp5#6c). - cargo fmt over installer/purge/remove (the gate was red on main). Steam delegation already logs `steam-remove` through `remove_selected_in` (verified with a temp HOME/XDG_DATA_HOME probe); its unbounded handoff wait is left to its own phase.
…s filter with upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sstays SizeAsc (documented divergence); delete still refused in Top viewVerified on cf20bbc: make test 572 passed / 0 failed (513 unit + 59 integration), make lint clean.
from therealTINHTUTE with love ❤️❤️❤️