Skip to content

support semver 3.x #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlonNR wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support semver 3.x #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyhelm3/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,4 +1042,4 @@ def client_version(self) -> semver.VersionInfo:
shell_formatted_command, capture_output=True, check=True, shell=True
)
version_str = proc.stdout.decode().removeprefix("v")
return semver.parse_version_info(version_str)
return semver.VersionInfo.parse(version_str)

@irt-shpc irt-shpc Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong replacement according to the upstream migration guide https://python-semver.readthedocs.io/en/latest/migration/replace-deprecated-functions.html

@AlonNR AlonNR Jul 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi thanks for the feedback,
you can see in https://github.com/python-semver/python-semver/blob/master/src/semver/version.py#L762
that VersionInfo is an alias of Version

if you prefer, I can align all usages of semver.VersionInfo.parse in the repo to use semver.Version.parse instead

@AlonNR AlonNR Jul 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irt-shpc how do you wish to proceed?

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ requires-python = ">=3.10"
dependencies = [
"pyyaml >= 6.0.2,<7",
"pydantic >= 2.10.6,<3",
"semver >= 2.9.1,<3"
"semver >= 2.9.1,<4"
]

[dependency-groups]
Expand Down
8 changes: 4 additions & 4 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.