support semver 3.x - #45
Open
AlonNR wants to merge 1 commit into
Open
Conversation
PR azimuth-cloud#41 explicitly restricts semver to versions >=2.9.1,<3 while latest release is 3.0.4 this PR extends supported range to <4 and replaces one use of the deprecated `semver.parse_version_info` with `semver.VersionInfo.parse` which is used by the rest of this project.
irt-shpc
requested changes
Jul 24, 2026
| ) | ||
| version_str = proc.stdout.decode().removeprefix("v") | ||
| return semver.parse_version_info(version_str) | ||
| return semver.VersionInfo.parse(version_str) |
Contributor
There was a problem hiding this comment.
This is the wrong replacement according to the upstream migration guide https://python-semver.readthedocs.io/en/latest/migration/replace-deprecated-functions.html
Author
There was a problem hiding this comment.
hi thanks for the feedback,
you can see in https://github.com/python-semver/python-semver/blob/master/src/semver/version.py#L762
that VersionInfo is an alias of Version
if you prefer, I can align all usages of semver.VersionInfo.parse in the repo to use semver.Version.parse instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #41 explicitly restricts semver to versions >=2.9.1,<3 while latest release is 3.0.4
this PR extends supported range to <4
and replaces one use of the deprecated
semver.parse_version_infowithsemver.VersionInfo.parsewhich is used by the rest of this project.