Repository navigation
feat(compose): reach the shaide server at http://shaide-server like on k8s (SHD-1088) - #36
Closed
janosmurai wants to merge 2 commits into
Closed
janosmurai wants to merge 2 commits into
janosmurai wants to merge 2 commits into
Conversation
8 of 12 tasks
janosmurai
force-pushed
the
SHD-1086/webapp-server-url
branch
2 times, most recently
from
October 19, 2026 13:15
fae38f3 to
2b9bc90
Compare
Signed-off-by: janosmurai <janos.murai@axem.dev>
…8s (SHD-1088) Signed-off-by: janosmurai <janos.murai@axem.dev>
janosmurai
force-pushed
the
SHD-1086/webapp-server-url
branch
from
October 20, 2026 13:25
2b9bc90 to
b406209
Compare
Contributor
Author
|
Superseded by #37: the branch was renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Related issue
Closes SHD-1088
Part of SHD-1086, which adds
SHAIDE_SERVER_URLto the webapp.Description
The webapp's Node server, not the browser, connects to the shaide server, so users had to enter an address that resolves inside the
webappcontainer. Enteringhttp://localhost:8080failed with "Could not reach the server to sign in". Thewebappservice now getsSHAIDE_SERVER_URL.To keep compose as close to the k8s deployment as possible, the containers now reach the server at the same address as on k8s,
http://shaide-server:shaide_server->shaide-server, since k8s Service names can't contain_. It was the only compose service with an underscore. Updated incompose.yaml,compose.kc.yaml, the KC notifications Caddyfile, the platform-discovery test stack and thejustfile.cap_drop: [ALL].SHAIDE_SERVER_FQDNandSHAIDE_SERVER_PORTmean what they mean on k8s: where the other containers reach the server. They default toshaide-serverand80, the values the installer gives the control panel.SHAIDE_SERVER_HOST_PORT(default8080) is the port the server is published on, on the host.SHAIDE_SERVER_URLjust stack app(containerized server)http://shaide-servershaide-server:80just dev app(native server)http://host.docker.internal:8080host.docker.internal:8080The
webappservice also gets thehost.docker.internal:host-gatewayentry the control panel already has, so the native mode resolves.Validation
cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningscargo build --verbose --all-featurescargo test --verbose --all-featuresAdditional validation details:
docker compose configresolves the addresses in the table above in both modes.test/kc-composepasses (27 tests). I added assertions that KC reaches the server athttp://shaide-serverand that the server's container port is 80.docker compose configacceptstest/platform-discovery/compose.yaml.appprofiles) under a separate project name. The server loggedListening at http://0.0.0.0:80. Sign-in returned 200 from the host on the published port, from thewebappcontainer athttp://shaide-serverand from thecontrol-panelcontainer atshaide-server:80.Deployment and compatibility
Local compose only. No server, API or database changes.
For existing local setups:
SHAIDE_SERVER_HOST_PORTinstead ofSHAIDE_SERVER_PORT. The KC operator guide is updated.shaide_servercontainer.just services-upandjust stackremove it with--remove-orphans; with plain compose, rundocker compose --profile '*' down --remove-orphansonce.Webapp images that predate axem-solutions/shaide_app_client#32 ignore
SHAIDE_SERVER_URL, so this is safe to merge first.Documentation
The README's Docker compose section explains the addresses and variables. The compose comments, the KC operator guide and the platform-discovery README are updated.
Checklist
Signed-off-bytrailer (git commit -s).Additional information
Related: axem-solutions/shaide_app_client#32 (app) and axem-solutions/shaide#55 (k8s installer).
AI assistance:
🤖 Generated with Claude Code
https://claude.ai/code/session_015XRChLGwyiDuPLPYGFiQkk