Repository navigation
feat(webapp): pass the shaide server URL to the webapp (SHD-1089) - #55
Closed
janosmurai wants to merge 1 commit into
Closed
janosmurai wants to merge 1 commit into
janosmurai wants to merge 1 commit into
Conversation
Signed-off-by: janosmurai <janos.murai@axem.dev>
11 of 14 tasks
11 of 14 tasks
Contributor
Author
|
Superseded by #56: the branch was renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Related issue
Closes SHD-1089
Part of SHD-1086, which adds
SHAIDE_SERVER_URLto the webapp.Description
The webapp's Node server, not the browser, connects to the shaide server, so users had to type the in-cluster address
http://shaide-serverinto the settings panel. The URL they'd naturally try, their port-forward or ingress URL, fails with "Could not reach the server to sign in".The webapp Deployment (
pkg/iac/shaide/internal/components/webapp/deploy.go) now setsSHAIDE_SERVER_URL=http://shaide-server. A webapp image with axem-solutions/shaide_app_client#32 then signs users in to that server, hides the Server URL field, and ignores any URL a client sends.The existing
SHAIDE_SERVER_FQDNandSHAIDE_SERVER_PORTvariables are unchanged.Validation
gofmt.go test ./...passed in every affected Go module.Additional validation details:
pkg:go build ./...,go vet ./iac/shaide/...andgo test ./...pass.installer(consumespkgviareplace):go build ./...andgo test ./...pass.Deployment and operational impact
pulumi uprolls the webapp pod (the strategy isRecreate).Documentation
docs/architecture/application-layer.mdnow describesSHAIDE_SERVER_URLin the webapp component section.Checklist
Signed-off-bytrailer (git commit -s).On tests: the webapp component has no test file, and the change is a static env entry that the existing Pulumi component tests don't cover.
Additional information
Related: axem-solutions/shaide_app_client#32 (app) and axem-solutions/shaide_server#37 (local compose).
AI assistance:
🤖 Generated with Claude Code
https://claude.ai/code/session_015XRChLGwyiDuPLPYGFiQkk