Skip to content

feat(webapp): pass the shaide server URL to the webapp (SHD-1089) - #55

Closed
janosmurai wants to merge 1 commit into
mainfrom
SHD-1086/webapp-server-url
Closed

janosmurai wants to merge 1 commit into
mainfrom
SHD-1086/webapp-server-url

Conversation

@janosmurai

@janosmurai janosmurai commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Type of change

  • New feature
  • Bug fix
  • Breaking change
  • Refactoring or maintenance
  • Documentation update

Related issue

Closes SHD-1089

Part of SHD-1086, which adds SHAIDE_SERVER_URL to the webapp.

Description

The webapp's Node server, not the browser, connects to the shaide server, so users had to type the in-cluster address http://shaide-server into the settings panel. The URL they'd naturally try, their port-forward or ingress URL, fails with "Could not reach the server to sign in".

The webapp Deployment (pkg/iac/shaide/internal/components/webapp/deploy.go) now sets SHAIDE_SERVER_URL=http://shaide-server. A webapp image with axem-solutions/shaide_app_client#32 then signs users in to that server, hides the Server URL field, and ignores any URL a client sends.

The existing SHAIDE_SERVER_FQDN and SHAIDE_SERVER_PORT variables are unchanged.

Validation

  • Changed Go files were formatted with gofmt.
  • go test ./... passed in every affected Go module.

Additional validation details:

  • pkg: go build ./..., go vet ./iac/shaide/... and go test ./... pass.
  • installer (consumes pkg via replace): go build ./... and go test ./... pass.

Deployment and operational impact

  • Adds one env var to the webapp Deployment. The next pulumi up rolls the webapp pod (the strategy is Recreate).
  • Webapp images that predate shaide_app_client#32 ignore the variable, so this is safe to roll out before the new image.
  • To roll back, revert the commit. The webapp then falls back to the free-form Server URL field.

Documentation

docs/architecture/application-layer.md now describes SHAIDE_SERVER_URL in the webapp component section.

Checklist

  • I added or updated tests for changed behavior, or explained why tests are not needed.
  • I updated documentation for deployment, configuration, topology, or operational changes.
  • My commits follow the Conventional Commits specification.
  • Every commit includes a Signed-off-by trailer (git commit -s).
  • I did not commit Pulumi state, kubeconfigs, chart archives, model artifacts, credentials, tokens, or plaintext secrets.

On tests: the webapp component has no test file, and the change is a static env entry that the existing Pulumi component tests don't cover.

Additional information

Related: axem-solutions/shaide_app_client#32 (app) and axem-solutions/shaide_server#37 (local compose).

AI assistance:

  • Tool: Claude Code
  • Model: Claude Opus 5.5
  • Used for: Deployment env change, docs line and this description
  • Human verification: pending review

🤖 Generated with Claude Code

https://claude.ai/code/session_015XRChLGwyiDuPLPYGFiQkk

Signed-off-by: janosmurai <janos.murai@axem.dev>
@janosmurai
janosmurai requested a review from nemethk as a code owner October 18, 2026 18:09
@janosmurai janosmurai changed the title feat(webapp): pass the shaide server URL to the webapp (SHD-1086) feat(webapp): pass the shaide server URL to the webapp (SHD-1089) Oct 19, 2026
@janosmurai

Copy link
Copy Markdown
Contributor Author

Superseded by #56: the branch was renamed to SHD-1089/webapp-server-url after the work moved to its own ticket, SHD-1089.

@janosmurai janosmurai closed this Oct 20, 2026
@janosmurai
janosmurai deleted the SHD-1086/webapp-server-url branch October 20, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant