Skip to content

feat(webapp): pass the shaide server URL to the webapp (SHD-1089) - #56

Merged
janosmurai merged 1 commit into
mainfrom
SHD-1089/webapp-server-url
Oct 20, 2026
Merged

janosmurai merged 1 commit into
mainfrom
SHD-1089/webapp-server-url

Conversation

@janosmurai

@janosmurai janosmurai commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Type of change

  • New feature
  • Bug fix
  • Breaking change
  • Refactoring or maintenance
  • Documentation update

Related issue

Closes SHD-1089

Part of SHD-1086, which adds SHAIDE_SERVER_URL to the webapp.

Description

The webapp Deployment (pkg/iac/shaide/internal/components/webapp/deploy.go) now sets SHAIDE_SERVER_URL=http://shaide-server.

The existing SHAIDE_SERVER_FQDN and SHAIDE_SERVER_PORT variables are unchanged.

Validation

  • Changed Go files were formatted with gofmt.
  • go test ./... passed in every affected Go module.

Additional validation details:

  • pkg: go build ./..., go vet ./iac/shaide/... and go test ./... pass.
  • installer (consumes pkg via replace): go build ./... and go test ./... pass.

Deployment and operational impact

  • Adds one env var to the webapp Deployment.

Documentation

docs/architecture/application-layer.md now describes SHAIDE_SERVER_URL in the webapp component section.

Checklist

  • I added or updated tests for changed behavior, or explained why tests are not needed.
  • I updated documentation for deployment, configuration, topology, or operational changes.
  • My commits follow the Conventional Commits specification.
  • Every commit includes a Signed-off-by trailer (git commit -s).
  • I did not commit Pulumi state, kubeconfigs, chart archives, model artifacts, credentials, tokens, or plaintext secrets.

On tests: the webapp component has no test file, and the change is a static env entry that the existing Pulumi component tests don't cover.

AI assistance:

  • Tool: Claude Code
  • Model: Claude Opus 5.5
  • Used for: Deployment env change, docs line and this description
  • Human verification: done

Signed-off-by: janosmurai <janos.murai@axem.dev>
@janosmurai
janosmurai force-pushed the SHD-1089/webapp-server-url branch from 61b8fcc to b0ab708 Compare October 20, 2026 18:13
@janosmurai
janosmurai merged commit 9c4894d into main Oct 20, 2026
@janosmurai
janosmurai deleted the SHD-1089/webapp-server-url branch October 20, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant