Skip to content

fix: remove manual role in durable functions #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valerena merged 4 commits into from
Apr 24, 2026
Merged

fix: remove manual role in durable functions #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1602bd5
fix: remove manual role in durable functions
valerena Mar 18, 2026
0c92285
chore: remove py3.9 tests. Minor fixes to other tests
valerena Mar 18, 2026
e827660
Merge branch 'master' into durable-functions-role
reedham-aws Apr 24, 2026
60dfff4
chore: add back python 3.9 unit tests
reedham-aws Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions .github/workflows/build_test_invoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,12 @@ jobs:
- version: '3.13'
type: 'Invoke'
file: 'tests/integration/build_invoke/python/test_python_3_13.py'
# - version: '3.14'
# type: 'Test'
# file: 'tests/integration/unit_test/test_unit_test_python3_14.py'
# - version: '3.14'
# type: 'Invoke'
# file: 'tests/integration/build_invoke/python/test_python_3_14.py'
- version: '3.14'
type: 'Test'
file: 'tests/integration/unit_test/test_unit_test_python3_14.py'
- version: '3.14'
type: 'Invoke'
file: 'tests/integration/build_invoke/python/test_python_3_14.py'
env:
PYTHON_VERSION_INSTALL: ${{ matrix.sam_cli_python || matrix.version }}
runs-on: ubuntu-latest
Expand Down Expand Up @@ -258,10 +258,9 @@ jobs:
- version: '3.4'
type: 'Test'
file: 'tests/integration/unit_test/test_unit_test_ruby3_4.py'
# Uncomment after SAM CLI supports Ruby3.4 and the build image is available
# - version: '3.4'
# type: 'Invoke'
# file: 'tests/integration/build_invoke/ruby/test_ruby_3_4.py'
- version: '3.4'
type: 'Invoke'
file: 'tests/integration/build_invoke/ruby/test_ruby_3_4.py'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
18 changes: 0 additions & 18 deletions nodejs22.x/hello-durable-ts/{{cookiecutter.project_name}}/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,6 @@ Description: >
Sample SAM Template for {{ cookiecutter.project_name }}

Resources:
# TODO: No longer necessary after https://github.com/aws/serverless-application-model/pull/3854
DurableFunctionRole:
Type: AWS::IAM::Role
Properties:
AssumeRolePolicyDocument:
Version: '2012-10-17'
Statement:
- Effect: Allow
Principal:
Service: lambda.amazonaws.com
Action: sts:AssumeRole
ManagedPolicyArns:
- arn:aws:iam::aws:policy/service-role/AWSLambdaBasicDurableExecutionRolePolicy

HelloWorldFunction:
Type: AWS::Serverless::Function # More info about Function Resource: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction
Properties:
Expand All @@ -33,7 +19,6 @@ Resources:
- {{arch}}
{%- endfor %}
{%- endif %}
Role: !GetAtt DurableFunctionRole.Arn
AutoPublishAlias: Live
DurableConfig:
ExecutionTimeout: 900
Expand Down Expand Up @@ -64,6 +49,3 @@ Outputs:
HelloWorldFunction:
Description: "Hello World Lambda Function ARN"
Value: !GetAtt HelloWorldFunction.Arn
HelloWorldFunctionIamRole:
Description: "IAM Role for Hello World function"
Value: !GetAtt DurableFunctionRole.Arn
18 changes: 0 additions & 18 deletions nodejs24.x/hello-durable-ts/{{cookiecutter.project_name}}/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,6 @@ Description: >
Sample SAM Template for {{ cookiecutter.project_name }}

Resources:
# TODO: No longer necessary after https://github.com/aws/serverless-application-model/pull/3854
DurableFunctionRole:
Type: AWS::IAM::Role
Properties:
AssumeRolePolicyDocument:
Version: '2012-10-17'
Statement:
- Effect: Allow
Principal:
Service: lambda.amazonaws.com
Action: sts:AssumeRole
ManagedPolicyArns:
- arn:aws:iam::aws:policy/service-role/AWSLambdaBasicDurableExecutionRolePolicy

HelloWorldFunction:
Type: AWS::Serverless::Function # More info about Function Resource: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction
Properties:
Expand All @@ -33,7 +19,6 @@ Resources:
- {{arch}}
{%- endfor %}
{%- endif %}
Role: !GetAtt DurableFunctionRole.Arn
AutoPublishAlias: Live
DurableConfig:
ExecutionTimeout: 900
Expand Down Expand Up @@ -64,6 +49,3 @@ Outputs:
HelloWorldFunction:
Description: "Hello World Lambda Function ARN"
Value: !GetAtt HelloWorldFunction.Arn
HelloWorldFunctionIamRole:
Description: "IAM Role for Hello World function"
Value: !GetAtt DurableFunctionRole.Arn
18 changes: 0 additions & 18 deletions python3.13/hello-durable/{{cookiecutter.project_name}}/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,6 @@ Description: >
Sample SAM Template for {{ cookiecutter.project_name }}

Resources:
# TODO: No longer necessary after https://github.com/aws/serverless-application-model/pull/3854
DurableFunctionRole:
Type: AWS::IAM::Role
Properties:
AssumeRolePolicyDocument:
Version: '2012-10-17'
Statement:
- Effect: Allow
Principal:
Service: lambda.amazonaws.com
Action: sts:AssumeRole
ManagedPolicyArns:
- arn:aws:iam::aws:policy/service-role/AWSLambdaBasicDurableExecutionRolePolicy

HelloWorldFunction:
Type: AWS::Serverless::Function # More info about Function Resource: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction
Properties:
Expand All @@ -33,7 +19,6 @@ Resources:
- {{arch}}
{%- endfor %}
{%- endif %}
Role: !GetAtt DurableFunctionRole.Arn
AutoPublishAlias: Live
DurableConfig:
ExecutionTimeout: 900
Expand All @@ -55,6 +40,3 @@ Outputs:
HelloWorldFunction:
Description: "Hello World Lambda Function ARN"
Value: !GetAtt HelloWorldFunction.Arn
HelloWorldFunctionIamRole:
Description: "IAM Role for Hello World function"
Value: !GetAtt DurableFunctionRole.Arn
18 changes: 0 additions & 18 deletions python3.14/hello-durable/{{cookiecutter.project_name}}/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,6 @@ Description: >
Sample SAM Template for {{ cookiecutter.project_name }}

Resources:
# TODO: No longer necessary after https://github.com/aws/serverless-application-model/pull/3854
DurableFunctionRole:
Type: AWS::IAM::Role
Properties:
AssumeRolePolicyDocument:
Version: '2012-10-17'
Statement:
- Effect: Allow
Principal:
Service: lambda.amazonaws.com
Action: sts:AssumeRole
ManagedPolicyArns:
- arn:aws:iam::aws:policy/service-role/AWSLambdaBasicDurableExecutionRolePolicy

HelloWorldFunction:
Type: AWS::Serverless::Function # More info about Function Resource: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction
Properties:
Expand All @@ -33,7 +19,6 @@ Resources:
- {{arch}}
{%- endfor %}
{%- endif %}
Role: !GetAtt DurableFunctionRole.Arn
AutoPublishAlias: Live
DurableConfig:
ExecutionTimeout: 900
Expand All @@ -55,6 +40,3 @@ Outputs:
HelloWorldFunction:
Description: "Hello World Lambda Function ARN"
Value: !GetAtt HelloWorldFunction.Arn
HelloWorldFunctionIamRole:
Description: "IAM Role for Hello World function"
Value: !GetAtt DurableFunctionRole.Arn
2 changes: 1 addition & 1 deletion tests/integration/unit_test/test_unit_test_python3_14.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class UnitTest_python3_14_cookiecutter_aws_sam_hello_python(UnitTestBase.Python3


class UnitTest_python3_14_cookiecutter_aws_sam_hello_durable_python(UnitTestBase.Python314UnitTestBase):
directory = "python3.13/hello-durable"
directory = "python3.14/hello-durable"
code_directories = ["hello_world"]
test_dependencies = True

Expand Down
Loading