Skip to content

fix: remove manual role in durable functions#542

Merged
valerena merged 4 commits into
aws:masterfrom
valerena:durable-functions-role
Apr 24, 2026
Merged

fix: remove manual role in durable functions#542
valerena merged 4 commits into
aws:masterfrom
valerena:durable-functions-role

Conversation

@valerena
Copy link
Copy Markdown
Contributor

@valerena valerena commented Mar 18, 2026

In the initial launch, SAM didn't automatically create the appropriate role to use with durable functions, but that's been fixed for a while.

There were some other issues that came when running the tests, so fixing those too

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

In the initial launch, SAM didn't automatically create the appropriate
role to use with durable functions, but that's been fixed for a while.
@valerena valerena requested a review from a team as a code owner March 18, 2026 21:19
seshubaws
seshubaws previously approved these changes Mar 18, 2026
@valerena
Copy link
Copy Markdown
Contributor Author

The Java11 failure seems to be an issue between Docker and the JDK. There's a thread about this issue in Mac with a good explanation: docker/for-mac#7573 (comment)

The Python issue seems to be with xgboost, potentially because we're using a really old version. Although if it's because of that, then it's weird that it's only failing in Python3.11 and not in newer versions

reedham-aws
reedham-aws previously approved these changes Mar 30, 2026
@reedham-aws reedham-aws dismissed stale reviews from seshubaws and themself via e827660 April 24, 2026 17:08
@valerena valerena enabled auto-merge (squash) April 24, 2026 18:44
@valerena valerena merged commit 15fe883 into aws:master Apr 24, 2026
98 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants