Repository navigation
feat(client): add optional shared UI chat pilot - #641
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
|
Independent review covered the complete base a30056c to head 71fd77b diff and affected Classic event routing, widget lifecycle, renderer composition, input ownership, privacy and CMake code, cross-checked against the reviewed shared ABI. Separate delta reviews cover c1f5695 and final 16e3c21. No actionable findings remain at this head.
The final head passes the production-adapter C17 fixture, ASan/UBSan, focused LLVM coverage, privacy tests, import-history and whitespace checks. Pinned full Linux wrapper builds pass enabled (78 passed, 23 hardware tests skipped) and disabled (77 passed, 23 skipped); the disabled worker had no optional SDK/font mounts or cache entries. Source and dependency identities are retained in private task evidence. These are CPU build/fixture results, not hardware gameplay qualification. Native isolated gameplay acceptance and current-head required hosted CI are still pending, so the PR remains draft. No package publication, deployment or merge is authorized by this receipt. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Independent review covered the complete base a30056c to head 71fd77b diff and affected Classic event routing, widget lifecycle, renderer composition, input ownership, privacy and CMake code, cross-checked against the reviewed shared ABI. Separate delta reviews cover c1f5695 and final 16e3c21. No actionable findings remain at this head.
The final head passes the production-adapter C17 fixture, ASan/UBSan, privacy tests, import-history and whitespace checks. Pinned full Linux wrapper builds pass enabled (78 passed, 23 hardware tests skipped) and disabled (77 passed, 23 skipped); the disabled worker had no optional SDK/font mounts or cache entries. The documented full-module LLVM 23.1.3 coverage procedure and native LCOV export also pass: 131 fresh profiles, all 62 measured objects, 445/584 pilot lines covered. External Rust SDK coverage is not claimed. Separate isolated Classic gameplay on Vulkan/NVIDIA RTX 3090 verifies one visible SDL window, pilot focus and a single accepted local batch, held-key cancellation, popup precedence, retained privacy and no screenshot files after /screenshot command inputs. Client/server exit 0 and topology leases are released. Independent evidence review verifies the exact source/build receipt, numeric observations and cleanup, while preserving limits: no active-pilot pixels captured, no separately instrumented screenshot invocation, no packet/server-motion trace, and no IME/audio/performance qualification. Current-head required hosted CI remains pending, so the PR remains draft. No package publication, deployment or merge is authorized by this receipt. |
Summary
Add an experimental Tilewright UI chat panel to the maintained Classic client. Both the build option and runtime switch default to off, so normal Classic builds require no new SDK or font assets.
Implementation / behavior
The opt-in panel uses the shared embedded C ABI and CPU text renderer inside an existing Classic widget. Classic keeps its SDL window, event loop, GPU renderer and presenter. The existing chat remains available; the pilot accepts only local echo and sends no command or packet, including slash-prefixed text.
Input ownership, held-key cancellation, IME/Enter handling and exact presentation acknowledgements follow the host lifecycle. Popup precedence and capture privacy remain active. Explicit SDK/header/font inputs are verified locally; CMake does not fetch them. The panel and its bounded history are temporary and are not persisted.
Validation
16e3c21b51c42e0c4ad158fdb38f2367517b2f78./screenshotcommand inputs. Client/server exit cleanly and all topology leases are released. Independent evidence review checked the exact source/build binding and these limits.Limitations / follow-up
Readiness is controlled by the live PR delivery gate, including required hosted CI and the validation above. The current SDK is an explicitly supplied, reviewed source candidate; no Tilewright UI package publication or platform distribution qualification is claimed. Real OS IME, renderer recovery, other platforms, visual quality, performance and audio require their own evidence. PrintScreen was not exercised; the runtime check used
/screenshotcommand inputs, the retained-privacy state and absence of output files. The pilot is not a network-chat cutover, and active pilot state remains excluded from captures. The owner merges.