Skip to content

feat: add embedded chat panels and field contexts - #2

Merged
zoeyrose merged 11 commits into
mainfrom
feat/embedded-ui-contexts-20261031
Nov 2, 2026
Merged

zoeyrose merged 11 commits into
mainfrom
feat/embedded-ui-contexts-20261031

Conversation

@zoeyrose

@zoeyrose zoeyrose commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Add opt-in embedded chat panels and single-value controls so existing applications can host the shared UI inside their own layout. This prepares the selected editor inspector and Classic chat-pilot milestone.

  • Keep each context's composition fixed: existing Demo, embedded ChatPanel, or SingleField. Reuse the one editable slot and existing typography; the host owns document/game policy and presentation.
  • Field submissions preserve the exact draft, support empty values, and carry binding/text identity. Atomic rebinding retires old focus and preedit while retaining queued actions.
  • Explicit attachment changes invalidate old geometry immediately. Extend C ABI 2 with new functions and sized structs while preserving existing layouts and Demo behavior.
  • Keep Classic/editor integration, networking, production rendering performance, accessibility qualification and package publication outside this change.

Validation at adc5486: independent full and delta review found no actionable defects. Integrated all-feature formatting, architecture, workspace tests/docs and strict Clippy pass against the exact renderer 0.6.1 candidate af2b648. WebAssembly compilation and default/CPU C17 smoke suites pass. All checks used isolated offline candidates with explicit external renderer overrides; they do not establish registry-only or actual consumer runtime acceptance.

Separate consumer pilots using this exact UI head have since passed bounded native acceptance: an editor shared field with Unicode/World review/history and OS IME handling, and Classic's opt-in local chat panel with held-key cancellation and popup precedence. Those host changes remain separate from this API PR; candidate evidence does not establish registry qualification.

All UI/app packages remain unpublished. PR #1 is now merged, and this PR targets main. The owner rebased it to 93f36efb1efe6658e52b3af747616c00ec131a9c; independent review verified that both the head tree and base tree exactly match the previously reviewed integration. Current-head hosted Rust, C ABI, C/SDL and browser checks pass. The owner merges.

Registry integration update at b22f74dfc1370d4c5bca582c99efa47465eb0705: merged reviewed parent d2b5c90d5c16a306a5271d0f2cbc958c40dc1e2e, replacing active renderer requirements with the fully published 0.6.2 family from immutable renderer release v1.21.0 / source 55f13ac311a5574b242e2520942377e51fd6b7cb. This supersedes the historical 0.6.1 registry blocker. The committed authentic registry-only Cargo.lock is byte-identical to the reviewed parent; no local renderer override was used.

Fresh independent review examined the entire parent merge delta and its semantic interaction with the embedded feature and found no actionable P0–P3 findings. The exact merged head passed architecture/source checks, formatting, all workspace/all-target/all-feature Rust tests and doctests, strict Clippy, C17 ABI/embedded smoke and lifecycle checks, C/SDL dummy-driver host checks, and wasm32 compilation in isolated registry-only builds. These checks do not qualify desktop IME, accessibility, production performance, or Classic/editor consumer adoption; the earlier private candidate consumer evidence remains distinct. No new UI/app publication is authorized.

@zoeyrose

Copy link
Copy Markdown
Contributor Author

Fresh-context independent integrated review covers the complete embedded-context diff at 38eeb96 and the subsequent parent/dependency delta through adc5486, against parent 6f0aa2d.

Examined field/action identities, atomic binding and failed mutations, queue pressure, physical-key/IME ownership, attachment/clipping invalidation, prepared/displayed frames, C pointer/thread/poison contracts, additive ABI compatibility, native/browser action handling, tests and documentation. No actionable P0-P3 findings remain. Separate review of the parent's dependency delta also passed.

At this exact head, full workspace all-feature formatting, architecture, tests/docs and strict Clippy pass against exact renderer 0.6.1 candidate af2b648; WebAssembly compilation and both default/CPU C17 smoke suites pass. These are isolated offline candidate checks, not released-dependency evidence. No actual Classic/editor embedding, production performance or accessibility qualification is claimed.

The PR remains stacked and draft. Real registry dependencies/Cargo.lock/hosted CI and parent delivery remain pending.

@zoeyrose

Copy link
Copy Markdown
Contributor Author

Reviewed head: b22f74d

A fresh-context independent reviewer inspected the complete parent-integration delta from the previously reviewed PR2 head adc5486, incorporating reviewed PR1 parent d2b5c90. The review covered all 11 changed files, affected UI/App/C facade/rendering and host code, correctness, security/unsafe boundaries, concurrency/ownership, failure paths, tests and documentation. The 14 embedded feature files other than the expected combined roadmap remain byte-identical to the previous reviewed head. The reviewer found no actionable P0–P3 findings; no findings were declined. Prior whole-feature and delta reviews through adc5486 remain applicable to preserved code.

The authentic registry-only lock matches the reviewed parent byte-for-byte and selected renderer 0.6.2 archive checksums match immutable release v1.21.0, source 55f13ac311a5574b242e2520942377e51fd6b7cb. The unused workspace SDL renderer requirement is pinned separately and is not falsely counted as a selected lock package.

Exact-head validation passed: architecture/source and font checks (18+2+6), formatting, workspace/all-target/all-feature Rust tests, doctests, strict Clippy, CPU-prototype C17 ABI/embedded smoke and 256 lifecycle checks, C/SDL dummy-driver host and IME metadata checks, and wasm32 compilation. All four isolated validation lanes recorded immutable source, registry-only dependencies and no local renderer overrides. These do not establish real desktop IME/accessibility/performance qualification or transfer private candidate consumer evidence to registry-native consumer acceptance.

This remains a draft stacked PR pending parent delivery, default-branch retargeting and fresh hosted CI/gate checks. All UI/app packages remain unpublished.

@zoeyrose
zoeyrose added this pull request to stack #3 October 31, 2026 13:46
Base automatically changed from feat/shared-ui-prototype-20261031 to main October 31, 2026 13:46
@zoeyrose
zoeyrose force-pushed the feat/embedded-ui-contexts-20261031 branch from b22f74d to 93f36ef Compare October 31, 2026 13:46
@zoeyrose

zoeyrose commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Fresh-context independent semantic review of the owner's rebase onto merged PR #1 / main, covering exact head 93f36efb1efe6658e52b3af747616c00ec131a9c and base 3111b832ea9a55bdc397cee62705961a02f48883.

No actionable P0–P3 findings. No fixes or declined findings were necessary. Read repository guidance, intent, prior whole-feature and parent-integration reviews and validation evidence; inspected complete head/base deltas, feature-patch equivalence, rebased ancestry/range-diff and affected field transactions, cancellation, attachment geometry, FFI boundary and CPU frame failure/resource paths against the contract.

The new head tree exactly equals previously reviewed b22f74dfc1370d4c5bca582c99efa47465eb0705 (36be64a772b6c894a1fe2b9b3cb53bdcbfe2bb8f). The new base tree exactly equals previously reviewed parent d2b5c90d5c16a306a5271d0f2cbc958c40dc1e2e (d903470b329406bdacc4e83654f5d1c8bc504cdd). Their complete 15-file feature patches are byte-identical. The rebase introduces no new code/dependency/ABI/contract change or semantic base interaction; the existing full-feature and parent reviews therefore remain applicable to these exact bytes.

Independently reran rebased diff whitespace validation and architecture/dependency policy tests (18 architecture, 2 font-preparation, 6 font-pack), all passing. Reused prior immutable registry-only Rust/all-feature, C ABI, C SDL and WASM evidence only after verifying exact tree/patch equivalence; those heavy builds were not repeated locally. Current-head CI run 41207111053 also passes source/tests/strict Clippy, C ABI/lifecycle, C SDL/dummy-driver and browser compilation. No Dependency Review job is present in this PR run. No inline review threads exist.

The unchanged capability limits remain: no new OS IME, assistive-technology, production-performance or consumer-adoption qualification. UI/app packages remain unpublished; the owner merges.

@zoeyrose
zoeyrose marked this pull request as ready for review November 1, 2026 04:06
@zoeyrose zoeyrose self-assigned this Nov 1, 2026
@zoeyrose
zoeyrose merged commit 4fcb723 into main Nov 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant