Repository navigation
[v4/p8-public-json] refactor!: public JSON equals the AI SDK JSON - #242
Closed
cunninghamcard-bit wants to merge 1 commit into
Closed
cunninghamcard-bit wants to merge 1 commit into
cunninghamcard-bit wants to merge 1 commit into
Conversation
- The public JSON of results, stream parts, errors, recordings and options is the AI SDK's JSON: camelCase fields and type-tagged unions. Errors are tagged by the AI SDK error name (AI_APICallError, ...). - The call-layer tool result carries upstream's structured output. - Size and AspectRatio serialize as upstream's template strings. - The seven bindings follow the AI SDK JSON and the reduced C ABI; their decision and recording tests read the camelCase wire JSON, and a missing decision usage count is absent from the JSON. - The NoSuchProvider message suggests close names. The by-name provider entries stay until the bindings migrate. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A3WxDBWBA4ituJjXsHaEAa
4 of 12 tasks
6 tasks
cunninghamcard-bit
changed the title
9 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by li
Summary
Before: the public JSON of results, stream parts, errors, recordings and options uses aimux's own snake_case shapes, and errors are tagged aimux's way.
After: it is the AI SDK's JSON: camelCase fields, type-tagged unions, and errors tagged by the AI SDK error name (
AI_APICallError, ...). The call-layer tool result carries upstream's structured output, andSizeandAspectRatioserialize as upstream's template strings. The seven bindings follow.The by-name provider entries (
aimux_register_providersand the binding calls to it) stay until the bindings migrate to the new C ABI.Type of change
Checklist
cargo fmt --all -- --checkpassescargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepasses (cassette playback — no network/keys)README.md,docs/,rfc/,bindings/README.md)Notes for reviewers
Status: Draft, opened early so the series layout can be reviewed. The items under "Planned in follow-up pushes" land on this branch before it is marked ready.
cargo test --workspacehas not been run on this branch yet.Base64Bytesfor byte fields (including decision image data); JSONnullkept where upstream keeps it; upstream file tags;GeneratedFileas{base64, mediaType}; a constrainedtimestamp; camelCase config JSON for the by-name entries.name).🤖 Generated with Claude Code
https://claude.ai/code/session_01A3WxDBWBA4ituJjXsHaEAa