-
Notifications
You must be signed in to change notification settings - Fork 314
feat: Add support for Spark Acosh, Asinh, Atanh math expressions #3787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
08799b0
ddc4872
92c0c33
86b5dd0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| -- Licensed to the Apache Software Foundation (ASF) under one | ||
| -- or more contributor license agreements. See the NOTICE file | ||
| -- distributed with this work for additional information | ||
| -- regarding copyright ownership. The ASF licenses this file | ||
| -- to you under the Apache License, Version 2.0 (the | ||
| -- "License"); you may not use this file except in compliance | ||
| -- with the License. You may obtain a copy of the License at | ||
| -- | ||
| -- http://www.apache.org/licenses/LICENSE-2.0 | ||
| -- | ||
| -- Unless required by applicable law or agreed to in writing, | ||
| -- software distributed under the License is distributed on an | ||
| -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| -- KIND, either express or implied. See the License for the | ||
| -- specific language governing permissions and limitations | ||
| -- under the License. | ||
|
|
||
| -- ConfigMatrix: parquet.enable.dictionary=false,true | ||
|
|
||
| statement | ||
| CREATE TABLE test_acosh(d double) USING parquet | ||
|
|
||
| statement | ||
| INSERT INTO test_acosh VALUES (1.0), (2.0), (10.0), (100.0), (NULL), (cast('NaN' as double)), (cast('Infinity' as double)), (0.5) | ||
|
|
||
| query tolerance=1e-6 | ||
| SELECT acosh(d) FROM test_acosh | ||
|
|
||
| -- literal arguments | ||
| query tolerance=1e-6 | ||
| SELECT acosh(1.0), acosh(2.0), acosh(NULL) | ||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,31 @@ | ||||
| -- Licensed to the Apache Software Foundation (ASF) under one | ||||
| -- or more contributor license agreements. See the NOTICE file | ||||
| -- distributed with this work for additional information | ||||
| -- regarding copyright ownership. The ASF licenses this file | ||||
| -- to you under the Apache License, Version 2.0 (the | ||||
| -- "License"); you may not use this file except in compliance | ||||
| -- with the License. You may obtain a copy of the License at | ||||
| -- | ||||
| -- http://www.apache.org/licenses/LICENSE-2.0 | ||||
| -- | ||||
| -- Unless required by applicable law or agreed to in writing, | ||||
| -- software distributed under the License is distributed on an | ||||
| -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||||
| -- KIND, either express or implied. See the License for the | ||||
| -- specific language governing permissions and limitations | ||||
| -- under the License. | ||||
|
|
||||
| -- ConfigMatrix: parquet.enable.dictionary=false,true | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need to test with dictionary encoding. Dictionaries are unpacked before expressions are evaluated.
Suggested change
|
||||
|
|
||||
| statement | ||||
| CREATE TABLE test_asinh(d double) USING parquet | ||||
|
|
||||
| statement | ||||
| INSERT INTO test_asinh VALUES (0.0), (1.0), (-1.0), (100.0), (NULL), (cast('NaN' as double)), (cast('Infinity' as double)) | ||||
|
|
||||
| query tolerance=1e-6 | ||||
| SELECT asinh(d) FROM test_asinh | ||||
|
|
||||
| -- literal arguments | ||||
| query tolerance=1e-6 | ||||
| SELECT asinh(0.0), asinh(1.0), asinh(NULL) | ||||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,31 @@ | ||||
| -- Licensed to the Apache Software Foundation (ASF) under one | ||||
| -- or more contributor license agreements. See the NOTICE file | ||||
| -- distributed with this work for additional information | ||||
| -- regarding copyright ownership. The ASF licenses this file | ||||
| -- to you under the Apache License, Version 2.0 (the | ||||
| -- "License"); you may not use this file except in compliance | ||||
| -- with the License. You may obtain a copy of the License at | ||||
| -- | ||||
| -- http://www.apache.org/licenses/LICENSE-2.0 | ||||
| -- | ||||
| -- Unless required by applicable law or agreed to in writing, | ||||
| -- software distributed under the License is distributed on an | ||||
| -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||||
| -- KIND, either express or implied. See the License for the | ||||
| -- specific language governing permissions and limitations | ||||
| -- under the License. | ||||
|
|
||||
| -- ConfigMatrix: parquet.enable.dictionary=false,true | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need to test with dictionary encoding. Dictionaries are unpacked before expressions are evaluated.
Suggested change
|
||||
|
|
||||
| statement | ||||
| CREATE TABLE test_atanh(d double) USING parquet | ||||
|
|
||||
| statement | ||||
| INSERT INTO test_atanh VALUES (0.0), (0.5), (-0.5), (1.0), (-1.0), (NULL), (cast('NaN' as double)), (2.0) | ||||
|
|
||||
| query tolerance=1e-6 | ||||
| SELECT atanh(d) FROM test_atanh | ||||
|
|
||||
| -- literal arguments | ||||
| query tolerance=1e-6 | ||||
| SELECT atanh(0.0), atanh(0.5), atanh(NULL) | ||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to test with dictionary encoding. Dictionaries are unpacked before expressions are evaluated.