feat: Add support for Spark Acosh, Asinh, Atanh math expressions#3787
Merged
andygrove merged 4 commits intoapache:mainfrom May 5, 2026
Merged
Conversation
Add inverse hyperbolic trigonometric functions by delegating to DataFusion's built-in implementations via CometScalarFunction. Includes SQL tests for column and literal arguments with edge cases.
andygrove
reviewed
May 5, 2026
| -- specific language governing permissions and limitations | ||
| -- under the License. | ||
|
|
||
| -- ConfigMatrix: parquet.enable.dictionary=false,true |
Member
There was a problem hiding this comment.
No need to test with dictionary encoding. Dictionaries are unpacked before expressions are evaluated.
Suggested change
| -- ConfigMatrix: parquet.enable.dictionary=false,true |
andygrove
reviewed
May 5, 2026
| -- specific language governing permissions and limitations | ||
| -- under the License. | ||
|
|
||
| -- ConfigMatrix: parquet.enable.dictionary=false,true |
Member
There was a problem hiding this comment.
No need to test with dictionary encoding. Dictionaries are unpacked before expressions are evaluated.
Suggested change
| -- ConfigMatrix: parquet.enable.dictionary=false,true |
andygrove
reviewed
May 5, 2026
| -- specific language governing permissions and limitations | ||
| -- under the License. | ||
|
|
||
| -- ConfigMatrix: parquet.enable.dictionary=false,true |
Member
There was a problem hiding this comment.
No need to test with dictionary encoding. Dictionaries are unpacked before expressions are evaluated.
Suggested change
| -- ConfigMatrix: parquet.enable.dictionary=false,true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Acosh,Asinh, andAtanhinverse hyperbolic trigonometric expressionsacosh,asinh,atanhfunctions viaCometScalarFunctionTest plan
acosh.sql,asinh.sql,atanh.sqlCometSqlFileTestSuiteverified — all 6 tests pass (2 per function × dictionary=false/true)Related to #2084