Repository navigation
Account localization follow-ups (pt, tr, legal links, /u messages) and a bundle budget - #49
Merged
Merged
Conversation
…h başlatıcı as in the launcher, localized legal links, only the needed words on public profiles
…llowed, checked in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to the account localization (#48), and the bundle budget from the redesign plan.
common.legalholds the four labels in all six languages; the auth shell uses the same words, so there is one source./u/{handle}ships only the words it uses (profile, compare, level, trophy grades, shared parts) instead of the whole account bundle; a new e2e test opens it in German and fails on a missing message.scripts/check-bundle.mjs,scripts/bundle-budget.json, CI step after Build): every route has the first-load JavaScript it may use, 8 % above today's measurement; a new route without a budget fails, so a page says how heavy it may be. It needs no brand decision.Need help on this PR? Tag
@codesmith-botwith what you need.