fix: create logs PVC eagerly to avoid init-job scheduling deadlock - #2
Open
Kreibich04 wants to merge 1 commit into
Open
fix: create logs PVC eagerly to avoid init-job scheduling deadlock#2Kreibich04 wants to merge 1 commit into
Kreibich04 wants to merge 1 commit into
Conversation
The Init/Upgrade/ModulesUpdate Jobs and the StatefulSet all mount <name>-logs-pvc by name whenever the log volume is enabled (the default), but that PVC was only ever created lazily inside reconcileStatefulSet's own logic -- which itself only runs after the Init Job succeeds. Since the Init Job's pod can never schedule without the PVC, it never succeeds, and the operator deadlocks forever with the pod stuck Pending and "persistentvolumeclaim ... not found". Create the logs PVC in reconcilePVCs, alongside data/addons, so it exists before anything references it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Init/Upgrade/ModulesUpdate Jobs and the StatefulSet all mount -logs-pvc by name whenever the log volume is enabled (the default), but that PVC was only ever created lazily inside reconcileStatefulSet's own logic - which itself only runs after the Init Job succeeds.
Since the Init Job's pod can never schedule without the PVC, it never succeeds, and the operator deadlocks forever with the pod stuck Pending and "persistentvolumeclaim ... not found".
Create the logs PVC in reconcilePVCs, alongside data/addons, so it exists before anything references it.