Skip to content

Fix native skill discovery paths and explain missing skills - #772

Merged
sox8502 merged 7 commits into
mainfrom
daniel/skill-detection
Oct 26, 2026
Merged

sox8502 merged 7 commits into
mainfrom
daniel/skill-detection

Conversation

@sox8502

@sox8502 sox8502 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Skills use explicit native search roots. Cursor discovery, installation and isolated launch share the same root, and invocation reads the selected native file even when Cursor’s own loader ignores CURSOR_CONFIG_DIR. Antigravity accepts a directory-name fallback when name is absent. Customize adds collapsed, copyable detection details from the same catalog scan.

Consolidated catalog selection and diagnostics, removed duplicate scanning and test scaffolding, and fixed retirement of stale managed Cursor links. The cleanup removes 156 source lines net across both passes, including the invocation fix and its regression coverage. Native ownership, upload precedence, exclusions and collision safeguards are preserved. Related to #685; the reporter’s exact cause remains unconfirmed.

Validation:

  • Four independent Opus 5.5 reviewers, three rounds; final full-PR round has no blockers.
  • Rust fmt, Clippy, locked build, 1,286 unit tests and 19 CLI tests; 3 existing ignored tests.
  • UI assets regenerated; typecheck, localization/style lint and 433 UI tests.
  • macOS skill-change revision d3a6b1b5: Customize diagnostics/copy feedback, refresh after add/remove, upload precedence/exclusions, harness-filtered menus, native Cursor default/configured-root invocations, and unnamed BOM/CRLF Antigravity invocation.
  • Windows Server 2025 skill-change revision d3a6b1b5: catalog/diagnostics and actual native Cursor and unnamed Antigravity invocations; 70 skill regressions and managed-link regression pass.
  • Merged-head d4644a0f Greptile 5/5 with no unresolved actionable findings.
  • Merge current main, regenerate combined UI assets, and recheck Customize diagnostics/copy/refresh.
  • User-led functionality testing.
  • Windows 11 24H2 and exact reported Cursor 3.17.8 / Antigravity 1.4.0 (unavailable).

Final tests used Cursor CLI 2026.09.28-64d2043 (macOS) / 2026.10.22-27dcf5f (Windows), and Antigravity 1.4.7 on Windows. Screenshots and native invocation records were captured; video capture is unavailable. Shared-folder compatibility and recursive/plugin inventories remain deferred. CI results are shown in Checks.

@sox8502

sox8502 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues remain from this review.

Summary

The PR gives each harness explicit native skill search roots and adds copyable detection details to Customize.

  • Native skills now follow each agent’s own search paths.
  • Customize explains which native skills each agent finds.

No new actionable issues were found.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Roots[Native skill roots] --> Scan[Scan skills and record skipped folders]
  Uploads[Uploaded skills] --> Catalog[Select catalog entries]
  Scan --> Catalog
  Catalog --> API[Skills and detection details]
  API --> Customize[Customize list and copyable details]
  Catalog --> Selection[Select skill for the current harness]
  Selection --> Cursor[Cursor reads the selected SKILL.md]
Loading

Reviews (7) · Last reviewed commit: "Merge origin/main and regenerate combine..." · Reviewed by Greptile

Comment thread src/local/native_store.rs Outdated
Comment thread src/local/user_skills.rs Outdated
@sox8502

sox8502 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@sox8502
sox8502 marked this pull request as ready for review October 23, 2026 22:45
@sox8502

sox8502 commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@sox8502

sox8502 commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@sox8502

sox8502 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@sox8502

sox8502 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@sox8502
sox8502 merged commit be7fdc6 into main Oct 26, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant