Skip to content

feat(ship-check): carry Reviewed-at and Dismissed into the pipeline snapshot #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliasunder merged 2 commits into from
Sep 4, 2026
Merged

feat(ship-check): carry Reviewed-at and Dismissed into the pipeline snapshot #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab322fb
feat(ship-check): carry Reviewed-at and Dismissed into the pipeline s…
aliasunder Sep 4, 2026
81ac7e5
fix(ship-check): comment-mode Reviewed-at must not assume one head SHA
aliasunder Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/ship-check/skills/ship-check/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,13 +373,15 @@ pipeline conclusion. Update it on each monitoring pass as PR status evolves.

```
Ship check complete:
- Reviewed at: <last phase-reviewed SHA; delta since then checked in Phase 5>
- PR Review: N findings, M fixed (correctness, security, conditional)
- Code Quality: N findings, M fixed (conventions, readability)
- Test Audit: N findings, M fixed (test quality); K coverage gaps, J tests written
- Bug Check: N findings, M fixed (by dimension)
- Triage: N flagged findings triaged across all phases — M fixed, K deferred (L pre-existing gaps)
- PR Monitor: CI status, N bot comments resolved
- Deferred: <list each with flag category, or "none">
- Dismissed: N across phases (roll up the phases' proof-of-dismissal lines — or "none")
- Verdict: ship / ship-with-minor-fixes / needs-changes
```

Expand All @@ -395,13 +397,15 @@ Output the final summary after Phase 4 completes — this is the pipeline conclu

```
Ship check complete (comment mode):
- Reviewed at: <PR head SHA at Phase 4 completion — or per-phase SHAs when the head moved mid-pipeline (each phase reports its own)>
- PR Review: N findings commented (correctness, security, conditional)
- Code Quality: N findings commented (conventions, readability)
- Test Audit: N findings commented (test quality); K coverage gaps reported
- Bug Check: N findings commented (by dimension)
- Triage: N flagged findings triaged across all phases — M commented, K deferred
- PR Monitor: skipped (comment mode)
- Deferred: <list each with flag category, or "none">
- Dismissed: N across phases (roll up the phases' proof-of-dismissal lines — or "none")
- Verdict: ship / ship-with-minor-fixes / needs-changes
- Reviews posted: N (one per phase with findings)
```
Expand Down