feat(ship-check): carry Reviewed-at and Dismissed into the pipeline snapshot - #10
Merged
Conversation
…napshot The phase skills report their reviewed SHA and proof-of-dismissal (PR \#9), but the orchestrator's Ship-check-complete snapshots — the report a consumer actually reads — carried neither, so the concluding verdict still couldn't distinguish a reviewed PR from an unexamined one. Both reporting templates gain the two lines: Reviewed-at (the delta-review high-water mark in default mode, the reviewed head in comment mode) and a Dismissed roll-up of the phases' dismissal lines. (umm-actually finding on PR \#9, post-merge.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![umm-actually[bot]](https://avatars.githubusercontent.com/in/4233716?s=60&v=4){kind=small}
|
umm-actually re-reviewed at No new findings (1 tracked finding(s) across all runs). Context notes
umm-actually · deepseek/deepseek-v4-flash-0731 |
Phases run sequentially in comment mode and the head can move between dispatches, so a single reported SHA overstates what earlier phases saw. Reworded to the Phase 4 completion head with per-phase SHAs when the head moved — each phase already reports its own. (umm-actually finding on PR \#10.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #9, resolving the umm-actually finding that arrived just before it merged (issue comment 5547367668): the phase skills now carry the
Reviewed at/Dismissedoutput-honesty contract, but the orchestrator's ownShip check completesnapshots — the report a consumer actually reads — carried neither.Changes
Both reporting templates in the ship-check orchestrator skill gain the two lines:
Reviewed atnames the last phase-reviewed SHA (the delta-review high-water mark Phase 5 checks against);Dismissedrolls up the phases' proof-of-dismissal lines.Reviewed atnames the PR head SHA the phases reviewed; sameDismissedroll-up.🤖 Generated with Claude Code