Skip to content

fix: move wg.Add(1) before goroutine launch to prevent negative WaitGroup counter #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alajmo merged 1 commit into from
May 12, 2026
Merged

fix: move wg.Add(1) before goroutine launch to prevent negative WaitGroup counter #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/exec/text.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ func RunTextCmd(
}

// Copy over commands STDOUT.
wg.Add(1)
go func(client Client) {
defer wg.Done()
var err error
Expand All @@ -161,9 +162,9 @@ func RunTextCmd(
fmt.Fprintf(stderr, "%s", err)
}
}(t.client)
wg.Add(1)

// Copy over tasks's STDERR.
wg.Add(1)
go func(client Client) {
defer wg.Done()
var err error
Expand All @@ -177,7 +178,6 @@ func RunTextCmd(
fmt.Fprintf(stderr, "%s", err)
}
}(t.client)
wg.Add(1)

wg.Wait()

Expand Down
Loading