fix: move wg.Add(1) before goroutine launch to prevent negative WaitGroup counter#129
Merged
Merged
Conversation
…roup counter The goroutines for copying stdout/stderr were launched with defer wg.Done() before wg.Add(1) was called. If a goroutine completed before Add(1) executed, Done() would decrement the counter below zero, causing a panic. Fixes alajmo#124 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Thanks for fixing this. |
Contributor
Author
np - and thanks for merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
mani runwith--parallelintermittently panics with:Root Cause
In
core/exec/text.go, the stdout/stderr copy goroutines were launched withdefer wg.Done()beforewg.Add(1)was called. If a goroutine completed beforeAdd(1)executed,Done()would decrement the counter below zero, causing a panic.Fix
Move
wg.Add(1)to before eachgo func(...)call — the standard Go pattern for WaitGroups.Fixes #124