fix(ci): drop dangling needs: test from java-e2e (unbreaks main)#240
Merged
Conversation
PR #239 added a ``java-e2e`` job to ``ci.yml`` with ``needs: [build-server, test]``. ``test`` is the job name inside the separate ``ci-java-sdk.yml`` workflow, but ``needs:`` in GitHub Actions only resolves jobs in the *same* workflow file. The dangling reference invalidated ``ci.yml`` as a whole: every push to main produced a 0-job failure run with the workflow name displayed as ``.github/workflows/ci.yml`` (the file path) instead of ``CI``, and the push-event runs at https://github.com/agentspan-ai/agentspan/actions/runs/25955164702 (and many others since 3f748c5) failed instantly. The two workflows already run in parallel by virtue of being separate workflow files. Drop the dangling ``test`` dep; ``build-server`` (the actual server-jar producer that java-e2e consumes) is the only real prerequisite from inside ``ci.yml``. This is the same fix that's already on PR #238 (feat/pac-pae, commit bf36222); landing it on main unblocks every other open PR's CI run immediately rather than waiting for the larger PAC/PAE branch to land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #239 added a
java-e2ejob toci.ymlwithneeds: [build-server, test].testis the job name inside the separateci-java-sdk.ymlworkflow, but GitHub Actionsneeds:only resolves jobs in the same workflow file. The dangling reference invalidatesci.ymlas a whole:.github/workflows/ci.yml(the file path) instead ofCI.This also blocks pull_request runs for the
CIworkflow on every PR until the underlying workflow file becomes valid again, so every open PR has degraded CI.Change
Drop the dangling
testdep fromjava-e2e.needs. The two workflows already run in parallel by being separate workflow files;build-server(the actual server-jar producer that java-e2e consumes) is the only real prerequisite from insideci.yml.Test plan
yaml.safe_loadparses; 9 jobs, no brokenneeds:references.CIdisplayed as the workflow name.This is the same fix that's already on PR #238 (feat/pac-pae, commit
bf362224). Landing it here unblocks every open PR immediately rather than waiting for the larger PAC/PAE branch to land.