fix(java-e2e): move E2eSuite12HandoffApprove to new layout (cannot find symbol)#241
Merged
Conversation
PR #228 (approve() targets sub-execution under handoff, commit dd6ba05) added ``E2eSuite12HandoffApprove.java`` at the *old* test path, extending the now-deleted ``E2eBaseTest`` — same broken pattern that PR #239 surfaced for ``E2eSuite13ToolTypes`` and PR #240 unblocked at the workflow level. Move it into the new layout (PR #223 established): flat ``sdk/java/e2e/`` directory, no package, ``extends BaseTest``, class renamed to drop ``E2e``. Behaviour, assertions, and test ids unchanged — pure layout fix so ``compileTestJava`` succeeds. ## Verification * ``./gradlew compileTestJava`` (sdk/java) → BUILD SUCCESSFUL. Source: failing CI run on main commit 9d187ac: https://github.com/agentspan-ai/agentspan/actions/runs/25966916074/job/76332262258 (``cannot find symbol: E2eBaseTest`` × 5 in E2eSuite12HandoffApprove.java).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #228 (approve() targets sub-execution under handoff, commit
dd6ba05a) addedE2eSuite12HandoffApprove.javaat the old test path (sdk/java/src/test/java/ai/agentspan/e2e/), extending the now-deletedE2eBaseTest. PR #223 had earlier moved all e2e tests to a flatsdk/java/e2e/layout with no package andBaseTestas the parent class — the reviewer missed the convention.Result:
java-e2eonmain(and every PR's merge tree) fails with 5xcannot find symbol: E2eBaseTest. Same broken pattern PR #239 surfaced forE2eSuite13ToolTypesand PR #240 unblocked at the workflow level.Failing CI run: https://github.com/agentspan-ai/agentspan/actions/runs/25966916074/job/76332262258
Change
Apply the PR #223 layout:
sdk/java/src/test/java/ai/agentspan/e2e/E2eSuite12HandoffApprove.java→sdk/java/e2e/Suite12HandoffApprove.javapackage ai.agentspan.e2e;E2eSuite12HandoffApprove→Suite12HandoffApproveextends E2eBaseTest→extends BaseTestBehaviour, assertions, and test ids unchanged — pure layout fix.
Test plan
./gradlew compileTestJava(sdk/java) → BUILD SUCCESSFUL.java-e2ecompile cleanly.