Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions sdk/js/__test__/providers/volcengine.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';

// Mock the sign module before importing VolcengineProvider
vi.mock('../../src/providers/sign', () => ({
request: vi.fn(),
}));

import { VolcengineProvider } from '../../src/providers/volcengine.js';
import { request } from '../../src/providers/sign';

const mockedRequest = vi.mocked(request);

describe('VolcengineProvider', () => {
let provider: VolcengineProvider;

beforeEach(() => {
vi.clearAllMocks();
provider = new VolcengineProvider({
accessKey: 'test-access-key',
secretKey: 'test-secret-key',
});
});

describe('createSandbox - no duplicate keys from spread', () => {
it('should not include camelCase duplicates of PascalCase fields', async () => {
mockedRequest.mockResolvedValue({ Result: { SandboxId: 'sb-123' } });

await provider.createSandbox('func-123', 60, {
metadata: { key: 'val' },
cpuMilli: 1000,
memoryMB: 512,
});

expect(mockedRequest).toHaveBeenCalledTimes(1);
const bodyStr = mockedRequest.mock.calls[0][8] as string;
const body = JSON.parse(bodyStr);

// Should have PascalCase keys from explicit mapping
expect(body.FunctionId).toBe('func-123');
expect(body.CpuMilli).toBe(1000);
expect(body.MemoryMB).toBe(512);

// Should NOT have camelCase duplicates from spread
expect(body.cpuMilli).toBeUndefined();
expect(body.memoryMB).toBeUndefined();
expect(body.metadata).toBeUndefined();
});
});

describe('listSandboxes - no duplicate keys from spread', () => {
it('should not include camelCase duplicates of PascalCase fields', async () => {
// First call is listSandboxes, second is getApigDomains (ListTriggers)
mockedRequest
.mockResolvedValueOnce({ Result: { Sandboxes: [], Total: 0 } })
.mockResolvedValueOnce({ Result: { Items: [] } });

await provider.listSandboxes('func-123', {
sandboxId: 'sb-456',
pageNumber: 2,
pageSize: 20,
status: 'running',
});

// First call is the actual listSandboxes request
const bodyStr = mockedRequest.mock.calls[0][8] as string;
const body = JSON.parse(bodyStr);

// Should have PascalCase keys from explicit mapping
expect(body.FunctionId).toBe('func-123');
expect(body.SandboxId).toBe('sb-456');
expect(body.PageNumber).toBe(2);
expect(body.PageSize).toBe(20);
expect(body.Status).toBe('running');

// Should NOT have camelCase duplicates from spread
expect(body.sandboxId).toBeUndefined();
expect(body.pageNumber).toBeUndefined();
expect(body.pageSize).toBeUndefined();
expect(body.status).toBeUndefined();
});
});
});
2 changes: 0 additions & 2 deletions sdk/js/src/providers/volcengine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ export class VolcengineProvider extends BaseProvider {
MemoryMB: params.memoryMB,
MaxConcurrency: params.maxConcurrency,
RequestTimeout: params.requestTimeout,
...kwargs[0]
});

const response = await request(
Expand Down Expand Up @@ -263,7 +262,6 @@ export class VolcengineProvider extends BaseProvider {
PageSize: params.pageSize || 10,
ImageUrl: params.imageUrl,
Status: params.status,
...kwargs[0]
});

const response = await request(
Expand Down