fix(volcengine): remove duplicate camelCase keys in createSandbox/listSandboxes#175
Open
Ricardo-M-L wants to merge 1 commit intoagent-infra:mainfrom
Open
fix(volcengine): remove duplicate camelCase keys in createSandbox/listSandboxes#175Ricardo-M-L wants to merge 1 commit intoagent-infra:mainfrom
Ricardo-M-L wants to merge 1 commit intoagent-infra:mainfrom
Conversation
…tSandboxes JSON body Both createSandbox and listSandboxes explicitly map snake_case parameter fields to PascalCase body keys (e.g. cpuMilli -> CpuMilli, pageSize -> PageSize), then spread `...kwargs[0]` on top. The spread re-adds the original camelCase keys, producing a JSON body that contains both PascalCase and camelCase duplicates for every user-supplied field. Removed the redundant spread so the body only contains the explicitly mapped PascalCase keys as intended. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #174.
Both
createSandboxandlistSandboxesinsdk/js/src/providers/volcengine.tsbuild the JSON body by first explicitly mappingparams.xxxto PascalCase keys, then spreading...kwargs[0]on top — which re-adds every user-supplied camelCase key on top of its PascalCase equivalent.This PR removes the redundant spread, so the JSON body only contains the PascalCase keys as intended.
Test plan
sdk/js/__test__/providers/volcengine.test.tswith 2 tests coveringcreateSandboxandlistSandboxes— verifies PascalCase keys are present and camelCase keys are absent from the serialized body.Related
This is part of splitting closed PR #167 into focused single-bug PRs. Bugs 1 (#171) and 2 (#173) are already open individually. This PR handles Bug 3.
🤖 Generated with Claude Code