Repository navigation
Main's publish run reuses the merged pull request's proof again - #183
Merged
Merged
Conversation
…equest's proof Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
Contributor
|
Merge train notice: the merge train merges this pull request once it is green on current main; don't enable auto-merge. Generated by Claude Code |
Contributor
|
Live: this change is on the published page, as main The publish job opened the published page in a fresh Chromium and its live checks passed (PG-01, PD-01, PD-02): https://github.com/afflom/me/actions/runs/43977249372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Main's publish run for #162 (run 43914340317 on da96880) was cancelled at the job's 75-minute limit with nothing failing, so nothing was published. Thirty of those minutes were "Build and verify the holo through the locked SDK", proving in full, and the step "On main, the proof the merged pull request's page build kept" was skipped.
That step and the proof reuse behind it are written for a
pushto main. Since the merge train merges with the workflow's own token, no push run starts;deploy-watch.ymldispatchespages.ymlon main instead, so main's publish runs asworkflow_dispatch. The step's condition names onlypush, and the Justfile'sapprecipe reuses a kept proof only forpull_request:*,merge_group:*andpush:refs/heads/main. So since the train took over, every publish has proved in full.What changes
In the model
app/specs/pipeline/workflows/pages.yml.json, rendered again to.github/workflows/pages.yml:PRISM_PROOF_EVENTnames a dispatch started by the pipeline (github.actor == 'github-actions[bot]') as the push it stands for. A run a person starts by hand is stillworkflow_dispatchand still proves in full, as the Justfile says a manual run must.What is not changed: the Justfile, and the read-time check.
xtask proof-reusestill reuses a proof only if its attestation binds this checkout's model, the SDK image, Lean and every input file; anything else proves in full. A batch that merges two pull requests which both change proof inputs will still prove in full on main, since neither pull request's proof binds the merged tree.This touches a deliberate guard (a manual run proves in full), so it wants an owner's eye: the reading here is that the guard is about runs a person starts, and the pipeline's dispatch is the push event the train's token cannot produce.
Checks
tools/generators/run.sh --check(GN-01); the rendered workflow parses as YAML.xtaskand the conformance tests readpages.ymlfor other needles only (checked by search).cargo test -p repo-conformancewas still running here when this was opened.Not run: the change itself. It only takes effect on main's own publish run, so the first publish after it merges is the test; I will read that run's proof step and say what it did.
Generated by Claude Code